Skip to content

Conversation

@jreidinger
Copy link
Contributor

Problem

When adding libzypp service as part of registration failed, it provides ugly error

thread 'main' panicked at /home/abuild/rpmbuild/BUILD/agama/agama-lib/src/product/http_client.rs:85:81:
called `Result::unwrap()` on an `Err` value: Error("missing field `id`", line: 1, column: 378)

Solution

Properly report error and wrap it into registration response.

Testing

  • Added a new unit test
  • Tested manually

Screenshots

add service failed

Copy link
Contributor

@dgdavid dgdavid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seem that it is not part of this PR, but looking at the screenshot in the PR description is clear to me that we should take care of the order of these warnings. The last one should be at the top, after the one about registration.

@coveralls
Copy link

coveralls commented May 23, 2025

Coverage Status

coverage: 62.776% (+0.04%) from 62.732%
when pulling 86577c5 on better_reg_errors
into 4e3ccb2 on master.

@jreidinger jreidinger merged commit e2fe591 into master May 23, 2025
11 checks passed
@jreidinger jreidinger deleted the better_reg_errors branch May 23, 2025 11:38
@imobachgs imobachgs mentioned this pull request May 26, 2025
imobachgs added a commit that referenced this pull request May 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants