refactor(rust): extract network code to agama-network #2357
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
While working on the
agama monitorcommand, I needed to use theEventenum, which is defined inagama-server, fromagama-lib.agama-libis a dependency ofagama-server, so I decided to move theEventtoagama-lib. However, it depends on some network stuff which is defined inagama-server. So I had to move more stuff toagama-lib.Let's put aside the fact that we need to improve the
Eventenum (turning it into a composition of smaller events).Solution
To improve the code organization, I have added a new
agama-networkpackage which the business logic for the network area resides now. It is a big change, but it brings some benefits:Additionally, the
agama-utilspackage contains OpenAPI and D-Bus utilities but, in the future, it could even contain theBaseHTTPClientand other reusable code.Future work
settingsmodule should live inagama-lib, as it can be considered kind of an interface to the network settings.typesmodule still makes sense.Testing