feat(web): improve storage/ProposalFailedInfo#2323
Merged
Conversation
Provide users with more specific hints about where the problem could be, including cases involving LVM. Note: tests are still pending.
Use a single, concise explanation to describe failures in allocating space for mount points or file systems. This reduces code complexity and avoids overly technical language for what is essentially the same underlying issue.
ancorgs
reviewed
May 5, 2025
ancorgs
reviewed
May 5, 2025
ancorgs
approved these changes
May 5, 2025
Contributor
ancorgs
left a comment
ancorgs
left a comment
There was a problem hiding this comment.
Pre-approved (just the typo of "presense" needs to be fixed).
Fixes a typo and make translations less challenging by avoiding including "boot partition" as an element of the mount paths list. Co-Authored-By: Ancor Gonzalez Sosa <ancorgs@gmail.com>
Merged
imobachgs
added a commit
that referenced
this pull request
May 26, 2025
Prepare to release Agama 15: * #2258 * #2270 * #2277 * #2279 * #2283 * #2284 * #2285 * #2286 * #2287 * #2288 * #2291 * #2292 * #2293 * #2295 * #2297 * #2299 * #2300 * #2301 * #2302 * #2303 * #2305 * #2306 * #2307 * #2308 * #2309 * #2313 * #2314 * #2315 * #2317 * #2318 * #2319 * #2320 * #2321 * #2322 * #2323 * #2324 * #2325 * #2328 * #2329 * #2330 * #2331 * #2335 * #2336 * #2337 * #2338 * #2339 * #2340 * #2342 * #2345 * #2346 * #2348 * #2349 * #2350 * #2351 * #2352 * #2353 * #2354 * #2355 * #2357 * #2358 * #2359 * #2360 * #2361 * #2362 * #2363 * #2364 * #2365 * #2366 * #2368 * #2369 * #2370 * #2371 * #2372 * #2374 * #2377 * #2378 * #2379 * #2380 * #2381 * #2382 * #2384 * #2385 * #2386 * #2388 * #2389 * #2390 * #2391 * #2392 * #2394 * #2397 * #2398 * #2401 * #2403
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When a proposal fails because not able to allocate space for an logical volume, the warning alert shown to users does not provide enough information because it is only aware of such a situation for partitions.
Solution
To make such an alert aware of logical volumes but avoiding to entering in details and just mentioning affected mount paths.
Testing
Screenshots
Related to https://trello.com/c/vE4qvtDl (private link)