Skip to content

feat: use the HTTP + WebSocket API in all commands #2368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
imobachgs merged 19 commits into from
May 19, 2025
Merged

feat: use the HTTP + WebSocket API in all commands #2368

imobachgs merged 19 commits into from
May 19, 2025

Conversation

@imobachgs
Copy link
Contributor

@imobachgs imobachgs commented May 19, 2025 •
edited
Loading

Problem

The CLI still relies on D-Bus for some important actions like agama install, agama probe, etc. Additionally, it still relies on D-Bus for progress reporting.

Solution

This PR introduces some changes regarding the HTTP API:

  • Adapts the old D-Bus based actions to use the HTTP/API.
  • Adds two new "agama monitor" and "agama events" commands.

To implement these features, it was needed to add a new WebSocketClient which allows reading the events using the WebSocket.

Testing

  • Tested manually

Documentation

A new PR updating the documentation will follow.

To do

  • Create the PR updating the documentation.

Caveats

  • If the monitor is started while the software service is busy, it will block the reporting.

@imobachgs imobachgs changed the title Monitor feat: use the HTTP/API in all commands May 19, 2025
@imobachgs imobachgs marked this pull request as draft May 19, 2025 06:30
@imobachgs imobachgs changed the title feat: use the HTTP/API in all commands feat: use the HTTP + WebSocket API in all commands May 19, 2025
@coveralls
Copy link

coveralls commented May 19, 2025 •
edited
Loading

Coverage Status

coverage: 62.83% (-26.1%) from 88.891%
when pulling fc702df on monitor
into 369c21a on master.

@imobachgs imobachgs marked this pull request as ready for review May 19, 2025 12:05
jreidinger
jreidinger reviewed May 19, 2025
View reviewed changes
jreidinger
jreidinger reviewed May 19, 2025
View reviewed changes
@imobachgs imobachgs merged commit 3067373 into master May 19, 2025
10 checks passed
@imobachgs imobachgs deleted the monitor branch May 19, 2025 13:50
@jreidinger jreidinger mentioned this pull request May 19, 2025
Merged
jreidinger added a commit that referenced this pull request May 20, 2025
@jreidinger
run with tarpaulin also doctests (#2372)
1d839f4 
## Problem

The build is broken after
#2368 with failing doctest


## Solution

Fix CI to discover it next time and of course fix failing test.
@imobachgs imobachgs mentioned this pull request May 26, 2025
Merged
imobachgs added a commit that referenced this pull request May 26, 2025
@imobachgs
Update to release 15 (#2405)
39bd0ec 
Prepare to release Agama 15:

* #2258
* #2270
* #2277
* #2279
* #2283
* #2284
* #2285
* #2286
* #2287
* #2288
* #2291
* #2292
* #2293
* #2295
* #2297
* #2299
* #2300
* #2301
* #2302
* #2303
* #2305
* #2306
* #2307
* #2308
* #2309
* #2313
* #2314
* #2315
* #2317
* #2318
* #2319
* #2320
* #2321
* #2322
* #2323
* #2324
* #2325
* #2328
* #2329
* #2330
* #2331
* #2335
* #2336
* #2337
* #2338
* #2339
* #2340
* #2342
* #2345
* #2346
* #2348
* #2349
* #2350
* #2351
* #2352
* #2353
* #2354
* #2355
* #2357
* #2358
* #2359
* #2360
* #2361
* #2362
* #2363
* #2364
* #2365
* #2366
* #2368
* #2369
* #2370
* #2371
* #2372
* #2374
* #2377
* #2378
* #2379
* #2380
* #2381
* #2382
* #2384
* #2385
* #2386
* #2388
* #2389
* #2390
* #2391
* #2392
* #2394
* #2397
* #2398
* #2401
* #2403
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jreidinger jreidinger jreidinger approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@imobachgs @coveralls @jreidinger