Added NetworkManager config server as mandatory package for SLES and SLES SAP #2279
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreidinger
reviewed
Apr 24, 2025
| - gnome | ||
| mandatory_packages: | ||
| - NetworkManager | ||
| - NetworkManager-config-server |
Contributor
There was a problem hiding this comment.
I would like to add comment here with reason why it is there ( link to bugzilla is enough for me ). It will help with future introspection...Also should it be in Leap16?
Contributor
Author
There was a problem hiding this comment.
Not requested so far, @lkocman? what do you think?
jreidinger
approved these changes
Apr 25, 2025
Merged
imobachgs
added a commit
that referenced
this pull request
May 26, 2025
Prepare to release Agama 15: * #2258 * #2270 * #2277 * #2279 * #2283 * #2284 * #2285 * #2286 * #2287 * #2288 * #2291 * #2292 * #2293 * #2295 * #2297 * #2299 * #2300 * #2301 * #2302 * #2303 * #2305 * #2306 * #2307 * #2308 * #2309 * #2313 * #2314 * #2315 * #2317 * #2318 * #2319 * #2320 * #2321 * #2322 * #2323 * #2324 * #2325 * #2328 * #2329 * #2330 * #2331 * #2335 * #2336 * #2337 * #2338 * #2339 * #2340 * #2342 * #2345 * #2346 * #2348 * #2349 * #2350 * #2351 * #2352 * #2353 * #2354 * #2355 * #2357 * #2358 * #2359 * #2360 * #2361 * #2362 * #2363 * #2364 * #2365 * #2366 * #2368 * #2369 * #2370 * #2371 * #2372 * #2374 * #2377 * #2378 * #2379 * #2380 * #2381 * #2382 * #2384 * #2385 * #2386 * #2388 * #2389 * #2390 * #2391 * #2392 * #2394 * #2397 * #2398 * #2401 * #2403
jlausuch
added a commit
to jlausuch/os-autoinst-distri-opensuse
that referenced
this pull request
Jun 2, 2025
https://jira.suse.com/browse/AGM-147 A new Agama feature make our interfaces in openQA not to get an IP, therefore failing in most cases due to not resolving the network. To be consistent with the previous behavior, we need to add some new parameters in the boot process. Related: - https://trello.com/c/P6oGGmjH/4745-ui-handle-persistent-non-persistent-network-connections - Added NetworkManager config server as mandatory package for SLES and SLES SAP agama-project/agama#2279 - Added inst.copy_network to kernel cmdline and config server no-auto-default agama-project/agama#2291 - https://bugzilla.suse.com/show_bug.cgi?id=1241224
fsimorda
pushed a commit
to fsimorda/os-autoinst-distri-opensuse
that referenced
this pull request
Jun 3, 2025
https://jira.suse.com/browse/AGM-147 A new Agama feature make our interfaces in openQA not to get an IP, therefore failing in most cases due to not resolving the network. To be consistent with the previous behavior, we need to add some new parameters in the boot process. Related: - https://trello.com/c/P6oGGmjH/4745-ui-handle-persistent-non-persistent-network-connections - Added NetworkManager config server as mandatory package for SLES and SLES SAP agama-project/agama#2279 - Added inst.copy_network to kernel cmdline and config server no-auto-default agama-project/agama#2291 - https://bugzilla.suse.com/show_bug.cgi?id=1241224
dgdavid
added a commit
that referenced
this pull request
Jun 6, 2025
## Problem With the current approach to network configuration in **SLE 16**, it is possible that you end up with a system with no network at all. Why? - We started copying all connections to the target system, but that meant volatile connections were copied too and maybe the defaults are not wanted in the target system so now only the persistent connections are copied (the ones in **/etc/NetworkManager/system-connections**). - Some products install NetworkManager-config-server package which disables the auto-default DHCP probing on ethernet devices (see #2279) - Agama should: Warn the user. Allow the user to get out of that situation at any time. - https://bugzilla.suse.com/show_bug.cgi?id=1241969 - https://trello.com/c/P6oGGmjH/4745-ui-handle-persistent-non-persistent-network-connections ## Solution - The connections generated by nm-initrd-generator are moved instead of copied to ensure them are seeing as permanent and not as in-memory only by NM avoiding duplications and only the ones generated by nm-initrd-generator will be copied (**TO BE FIXED:** ibft, nbft and other kind of connections should be probably omitted). - If no connection is going to be copied the user will be warned but by now only in the networking section (there is no check of **NetworkManager-config-server** package yet for showing the warn). - The user can select which interfaces will be used for installation only and switch between made them persistent or not. - We have modified the way the connection is updated and we are now using the Update2 and AddConnection2 methods using the **NMSettingsAddConnection2Flags** and **NMSettingsUpdate2Flags** (see https://networkmanager.dev/docs/api/latest/nm-dbus-types.html#NMSettingsConnectionFlags) ## Current Network State In general, **If an explicit network configuration through the kernel cmdline is given then:** 1. Agama disables the auto default (no extra connections will be created by NM when the installer is run. 2. The connections created in dracut will be persisted (moved from /run to /etc) **If no explicit network configuration through the kernel cmdline is given then:** 1. In dracut there will be no disable of auto default and no move of any connection to /etc. 2. When Agama is started it will check if there are no persistent connections and in that case it will persist all the known by Agama (move them from /run to /etc), that is the case of the ones generated by NetworkManager like Wired 1, 2 3... Agama UI allows to modify the persistency of the connections it manages and in the future it could expose an option to modify the whole copy of the confiugration (already supported in the backend) as well as allow to modify the persistency of all the connections managed by NetworkManager. The UI will also shown a warning when there are no persistent connections configured but just in the Network section by now. **Note:** The copy of the persisted connections (from /etc) at the end of the installation is enabled by default (can be disabled with **inst.copy_network=0**). If disabled, it will not copy anything even if persisted in the UI. Therefore, if no specific network configuration is provided which is the "default path", the installed system will boot with the "defaults" connections in etc having network after the installation, of course if there is DHCP properly configured. For products which does not install the **NetworkManager-config-server** package this should not be neccesary and even a little bit annoying, but by now it is preferable than not having network. ## Testing - *Added a new unit test* - *Tested manually* ## Screenshots *If the fix affects the UI attach some screenshots here.*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
It was agreed to install the NetworkManager config server package for both products avoiding the ethernet devices probing and automatic configuration.
Solution
Define the NetworkManager-config-server package as mandatory for SLES-16 and SLES_SAP-16. (see also #2291)