Self-signed certificate support

[jreidinger]

Problem

Using registration server that uses self-signed certificate is not possible.

Solution

In this initial pull request implement question for user if certificate should be imported or not.

Testing

• Added a new unit test
• Tested manually

json used to invoke popup:

{
  "product": {
    "id": "SLES",
    "registrationCode": "test",
    "registrationUrl": "https://migration-rmt2.qe.nue2.suse.org"
  }
}

json to test unattended ( will return product not found on server instead of certificate product as I do not have any rmt with SLES16 support)

{
  "product": {
    "id": "SLES",
    "registrationCode": "test",
    "registrationUrl": "https://migration-rmt2.qe.nue2.suse.org"
  },
  "security": {
	  "sslCertificates": [{
		 "fingerprint": "F6:7A:ED:BB:BC:94:CF:55:9D:B3:BA:74:7A:87:05:EF:67:4E:C2:DB",
		"algorithm": "SHA1"
	  }
	 ]
  }
}

Screenshots

Documentation

Remember to look at it from the user's perspective. Yes you have made the compiler happy.
But will the humans even know about your contribution? Sometimes they cannot miss it,
other times they need advertisement and explanation.

Look for relevant sections and adjust:

• https://agama-project.github.io/ (source)
• Run: git ls-files '*.md'

[jreidinger]

@joseivanlopez thanks, changed popup looks really good. So now only rest of backend part for unattended support is missing.

[dgdavid]

NP: Probably not in the scope of this PR, but reveleaded here.

I believe we have to look for a way for not having a "primary" action but just the focused one for prompts like this where Agama shouldn't use a call to action. Agama should just prevent users trusting in the self certificate by accident focusing the Reject by default, but not encouraging/inviting users to reject it by using a primary action look&feel.

[imobachgs]

I have reviewed the Rust part.

[imobachgs]

It looks weird to me to have separate endpoints to set the registration code/email and the URL.

Perhaps in the future we might consider to add the URL to the registration params.

[jreidinger]

yeap, but code+email is together registration...not sure if it should be also part of registration method param and expect that all following registration of addons is forced to be on identical url.

[imobachgs]

Apart from two minor comments, the Rust part is looking good.

[imobachgs]

I would prefer to import the SSLFingerprintAlgorithm as you did with SSLFingerprint and SecuritryProxy.

[imobachgs]

You can save the explicit clone if you derive Copy. In an enum, it makes sense.

[imobachgs]

Is something missing here?

[jreidinger]

no, it is just for future download of certificate from URL if we decide to implement it. It is using Yast downloader, so I kind of expect that we will do it differently in agama.

[imobachgs]

Please, add a reference to this PR and you can merge :-)