Consider bootable RAIDs when resolving an omitted boot device #2388
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ancorgs
force-pushed
the
boot_from_candidate_raid
branch
from
d470ec1 to
52ef353
Compare
ancorgs
force-pushed
the
boot_from_candidate_raid
branch
from
52ef353 to
6056f90
Compare
Contributor
joseivanlopez
left a comment
joseivanlopez
left a comment
There was a problem hiding this comment.
Please, add a changelog entry.
Contributor
As agreed in IRC, this is part of a bigger change. A changelog entry will be added later. |
Merged
imobachgs
added a commit
that referenced
this pull request
May 26, 2025
Prepare to release Agama 15: * #2258 * #2270 * #2277 * #2279 * #2283 * #2284 * #2285 * #2286 * #2287 * #2288 * #2291 * #2292 * #2293 * #2295 * #2297 * #2299 * #2300 * #2301 * #2302 * #2303 * #2305 * #2306 * #2307 * #2308 * #2309 * #2313 * #2314 * #2315 * #2317 * #2318 * #2319 * #2320 * #2321 * #2322 * #2323 * #2324 * #2325 * #2328 * #2329 * #2330 * #2331 * #2335 * #2336 * #2337 * #2338 * #2339 * #2340 * #2342 * #2345 * #2346 * #2348 * #2349 * #2350 * #2351 * #2352 * #2353 * #2354 * #2355 * #2357 * #2358 * #2359 * #2360 * #2361 * #2362 * #2363 * #2364 * #2365 * #2366 * #2368 * #2369 * #2370 * #2371 * #2372 * #2374 * #2377 * #2378 * #2379 * #2380 * #2381 * #2382 * #2384 * #2385 * #2386 * #2388 * #2389 * #2390 * #2391 * #2392 * #2394 * #2397 * #2398 * #2401 * #2403
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adapts Agama to some historical behavior of YaST, but (hopefully) in a more structured and explicit way.
Historical background
YaST considers some software RAIDs to be bootable and, thus, it:
The criteria used by YaST is kind of arbitrary, based on some heuristic imposed by SUSE partners and refined over time. See this explanation.
To not break the existing use cases, we should keep the ability in Agama to install on those RAIDs. That’s relevant for:
But we also need the option to manipulate other RAID devices that are not considered to be candidates for a normal installation (ie. bootable). For example, to be able to select them at the web UI with any purpose.
Implementation
This pull request:
To address the first goal,
Systemnow offers four methodsavailable_drives,candidate_drives,available_md_raidsandcandidate_md_raids. Check the documentation for the exact meaning.To address the latter goal, this introduces the ability to automatically determine the boot device if the storage configuration omits
boot.devicebut specifies the root partition must be located at a bootable (candidate) RAID.Dependencies
This PR depends on yast/yast-storage-ng#1411