Skip to content

Conversation

@imobachgs
Copy link
Contributor

Problem

It is not possible to validate a profile since the iscsi.schema.json, introduced recently, is missing from the package.

Solution

Add the ìscsi.schema.json file to the agama-cli package. Now that the validation is performed in the client side, we might consider moving those files to another package. But, by now, let's fix the auto-installation.

@imobachgs imobachgs marked this pull request as ready for review May 5, 2025 06:38
Copy link
Contributor

@teclator teclator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@imobachgs imobachgs merged commit 6ac8650 into master May 5, 2025
6 of 7 checks passed
@imobachgs imobachgs deleted the add-iscsi-schema branch May 5, 2025 06:58
@imobachgs imobachgs mentioned this pull request May 26, 2025
imobachgs added a commit that referenced this pull request May 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants