Skip to content

fix(live): Rename "root" to "live-root" to avoid confusion with "root/root"#2288

Merged
lslezak merged 1 commit intomasterfrom
live_cleanup
Apr 23, 2025
Merged

fix(live): Rename "root" to "live-root" to avoid confusion with "root/root"#2288
lslezak merged 1 commit intomasterfrom
live_cleanup

Conversation

@lslezak
Copy link
Contributor

@lslezak lslezak commented Apr 23, 2025

Problem

The Live ISO sources contain root directory and root/root subdirectory. The top level "root" means / in the Live medium, the nested one is /root. That is confusing and someone even created root/.xinitrc file which is then stored as /.xinitrc in the Live system which is wrong. The same file is stored also at the correct location root/root/.xinitrc (/root/.xinitrc in the Live system).

We should remove the wrong files and rename the top level root to avoid mistakes.

Solution

  • Rename the top level root to live-root so it is more obvious that it is / in the Live system and not /root.
  • Removed duplicate /root/.mozilla/firefox/profile/user.js.template and root/.xinitrc, the same file is in the correct location at root/root (or live-root/root now).

Testing

  • Tested manually, the ISO builds fine locally and still boots 😃

Copy link
Contributor

@joseivanlopez joseivanlopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lslezak lslezak merged commit 70e7d98 into master Apr 23, 2025
8 checks passed
@lslezak lslezak deleted the live_cleanup branch April 23, 2025 11:53
@imobachgs imobachgs mentioned this pull request May 26, 2025
imobachgs added a commit that referenced this pull request May 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants