Closed
Conversation
This PR enables WebAssembly support for the orchard crate by: - Adding a target-specific override in Cargo.toml to pull in getrandom with its js feature on wasm32-unknown-unknown targets. - Removing the multicore feature from the default feature set to avoid atomics-related compile errors on wasm32 targets, making multicore opt-in. - Introducing a wasm feature flag for wasm-bindgen support and exposing the derive_orchard_address binding in lib.rs. - Updating pkg/test-derive.js to resolve the wasm file path correctly in an ES module context using import.meta.url. - Declaring bip39 as a runtime dependency in pkg/package.json so that npm install pulls in the mnemonic library. Verification: - cargo build --target wasm32-unknown-unknown completes successfully. - node pkg/test-derive.js prints a valid spending key, full viewing key, and raw address.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sk_isstoisk, theIssuanceKeystruct toIssuanceAuthorizingKey, and move to a two key structure (Renamesk_isstoimk, theIssuanceKeystruct toIssuanceMasterKey, and move to a two key structure #92)Copy + Into<i64>constraints