Rename sk_iss to imk, the IssuanceKey struct to IssuanceMasterKey, and move to a two key structure#92
Merged
vivek-arte merged 11 commits intozsa1from Nov 7, 2023
Merged
Conversation
PR Summary
The changes aim to improve determinism and randomness in various functions, thereby optimizing the algorithm performance. |
This was referenced Oct 25, 2023
PaulLaux
reviewed
Oct 26, 2023
Collaborator
There was a problem hiding this comment.
This Pr seems inconsistent with our current spec and with the previous version of the zips.
We have two options here:
- Align the number of issuance key components to two. With redpalas as the underling curve. There is no
IssuanceAuthorizingKeyin the zip, isn't it? - Redact this PR and merge as part of your bigger PR.
I prefer the first option since we need the external interface as fast as possible.
src/bundle/burn_validation.rs
Outdated
| let sk_iss = IssuanceKey::from_bytes([0u8; 32]).unwrap(); | ||
| let isk: IssuanceAuthorizingKey = (&sk_iss).into(); | ||
| let imk = IssuanceMasterKey::from_bytes([0u8; 32]).unwrap(); | ||
| let isk: IssuanceAuthorizingKey = (&imk).into(); |
Collaborator
There was a problem hiding this comment.
we have no isk in the spec. We need to have only two components: imk and ik.
This PR should reflect it.
src/issuance.rs
Outdated
| let incorrect_sk_iss = IssuanceKey::random(&mut rng); | ||
| let incorrect_isk: IssuanceAuthorizingKey = (&incorrect_sk_iss).into(); | ||
| let incorrect_imk = IssuanceMasterKey::random(&mut rng); | ||
| let incorrect_isk: IssuanceAuthorizingKey = (&incorrect_imk).into(); |
Collaborator
There was a problem hiding this comment.
This seems inconsistent. In the zip we have imk -> ik.
src/keys.rs
Outdated
| /// [orchardkeycomponents]: https://zips.z.cash/protocol/nu5.pdf#orchardkeycomponents | ||
| #[derive(Debug, Copy, Clone)] | ||
| pub struct IssuanceKey([u8; 32]); | ||
| pub struct IssuanceMasterKey([u8; 32]); |
Collaborator
There was a problem hiding this comment.
the documentation should point to our version of the spec with the write paragraph link.
Collaborator
There was a problem hiding this comment.
Please make sure that all newly added key components are properly documented.
vivek-arte
changed the title
sk_iss to imk and the IssuanceKey struct to IssuanceMasterKeysk_iss to imk, the IssuanceKey struct to IssuanceMasterKey, and move to a two key structure
PaulLaux
approved these changes
Nov 7, 2023
src/keys.rs
Outdated
Comment on lines
263
to
266
| /// Checks whether the Orchard-ZSA issuance key is valid //TODO: What are the criteria? | ||
| pub fn is_valid(self) -> Choice { | ||
| 1u8.into() | ||
| } |
Collaborator
There was a problem hiding this comment.
let's remove is_valid() and use CtOption::new(isk, true.into())
alexeykoren
pushed a commit
that referenced
this pull request
Jan 10, 2024
…izingKey`, and move to a two key structure (#92) This performs a consistent renaming of the issuance authorizing key to make it consistent with the ZIP. It also reworks the `IssuanceAuthorizingKey` struct in place of the `IssuanceKey` and `IssuanceAuthorizingKey` structs, as part of using a two key structure for issuance, as specified in ZIP 227.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR performs a consistent renaming of the issuance master key to make it consistent with the ZIP.
It also removes the
IssuanceAuthorizingKeystruct as part of using a two key structure for issuance, as specified in ZIP 227.