Protect bundle burn from adding assets with zero amount#60
Merged
Conversation
PR Summary
|
PaulLaux
approved these changes
May 29, 2023
dmidem
added a commit
that referenced
this pull request
Jun 26, 2023
Prevent the burning of assets with zero value.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request addresses a specific part of a three-point task:
AssetBasemore than once in a single transaction.For points 2 and 3, the existing
add_burnfunction in the bundle already prevents duplications and burning of native assets:add_burnis called with an existing asset, its value gets added to the existing value, rather than creating a duplicate entry.add_burnalready verifies if the added asset is native and returns an error if that's the case, disallowing the burning of native assets.This pull request addresses the first point: disallowing the burning of assets with zero value, a check that was previously missing.