Minimal API changes for Issuance in Client#43
Merged
alexeykoren merged 5 commits intozsa1from Feb 9, 2023
Merged
Conversation
alexeykoren
commented
Feb 6, 2023
- Added a Copy trait to be able to work with IssuanceAuthorizingKey and SigningKey in a same manner as with others
- from_bytes made public for Client
PaulLaux
approved these changes
Feb 7, 2023
Collaborator
PaulLaux
left a comment
There was a problem hiding this comment.
approved with comments.
src/keys.rs
Outdated
| } | ||
|
|
||
| pub(crate) fn from_bytes(bytes: &[u8]) -> Option<Self> { | ||
| /// Creates a spend validating key from its serialized form |
Collaborator
There was a problem hiding this comment.
/// Constructs an Orchard issuance validating key from uniformly-random bytes.
///
/// Returns `None` if the bytes do not correspond to a valid key .
Is better adjusted to the existing style.
tests/zsa.rs
Outdated
| .is_ok()); | ||
|
|
||
| let issue_bundle = sign_issue_bundle(unauthorized, rng, keys.isk().clone()); | ||
| let issue_bundle = sign_issue_bundle(unauthorized, rng, *keys.isk()); |
Collaborator
There was a problem hiding this comment.
let's go with
let issue_bundle = sign_issue_bundle(unauthorized, rng, keys.isk());
...
fn sign_issue_bundle(
unauthorized: IssueBundle<Unauthorized>,
mut rng: OsRng,
isk: &IssuanceAuthorizingKey,
) -> IssueBundle<Signed> {
let sighash = unauthorized.commitment().into();
let proven = unauthorized.prepare(sighash);
proven.sign(&mut rng, isk).unwrap()
}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.