ZSA burn functionality by alexeykoren · Pull Request #35 · QED-it/orchard

alexeykoren · 2022-12-07T11:14:42Z

For Builder, Added a method to add assets to burn
bvk computation now includes the burnt assets
Added Tests for bsk/bvk consistency for burning
Added E2E tests for assets burning

* Added .circleci/config.yml

Implements the issuer keys as IssuerAuthorizingKey -> isk IssuerVerifyingKey -> ik Test vectors generated with zcash_test_vectors repo

* Added NoteType to Notes * Added NoteType to value commitment derivation

* Circleci project setup (#1) * Added .circleci/config.yml * Added NoteType to Notes * reformated file * updated `derive` for NoteType * added note_type to value commit derivation * rustfmt * updated ci config * updated ci config * updated ci config * updated derive for note_type * added test for arb note_type * added test for `native` note type * zsa-note-encryption: introduce AssetType and encode and decode it in note plaintexts * zsa-note-encryption: extend the size of compact notes to include asset_type * fixed clippy warrnings * rustfmt * zsa-note-encryption: document parsing requirement * zsa-note-encryption: revert support of ZSA compact action * zsa_value: add NoteType method is_native * zsa-note-encryption: remove dependency on changes in the other crate * zsa-note-encryption: extract memo of ZSA notes * zsa-note-encryption: tests (zcash_test_vectors 77c73492) * zsa-note-encryption: simplify roundtrip test * zsa-note-encryption: more test vectors (zcash_test_vectors c10da464) * Circleci project setup (#1) * Added .circleci/config.yml * issuer keys implementation (#5) Implements the issuer keys as IssuerAuthorizingKey -> isk IssuerVerifyingKey -> ik Test vectors generated with zcash_test_vectors repo * Added NoteType to Notes (#2) * Added NoteType to Notes * Added NoteType to value commitment derivation * zsa-note-encryption: use both native and ZSA in proptests * zsa-note-encryption: test vector commit 51398c93 * zsa-note-encryption: fix after merge Co-authored-by: Paul <3682187+PaulLaux@users.noreply.github.com> Co-authored-by: Paul <lauxpaul@protonmail.com> Co-authored-by: Aurélien Nicolas <info@nau.re> Co-authored-by: Daniel Benarroch <danielbenarroch92@gmail.com>

+ Updated test bsk_consistent_with_bvk to verify mixed note types. + Added NoteType support to the builder and the bundle. + added split_flag to SpentInfo and as input to the Circuit (currently commented out) + added conditional cv_sum calculation (currently commented out) + added padding to actions

- added IssueBundle and IssueAction - added a builder for IssueBundle - added verify_issue_bundle() for consensus verification. - unit tests.

added tests in `tests/zsa.rs`

* disabled split notes and proof check for zsa transfer

* fixes and suggestions * changed "issuer" to "issuance" as per zcash#356 (comment) * terminology fixes * updated naming

* rename 2 note_type -> asset as per zcash#356 (comment) * added a dedicated type for "IssuanceAuth" * disabled codecov github action due to bad behavior. * extracted "is_asset_desc_of_valid_size()" into asset_id.rs

* improved `verify_issue_bundle()`

# Conflicts: # .circleci/config.yml # .github/workflows/bench.yml # .github/workflows/ci.yml # .github/workflows/lints-stable.yml # Cargo.toml # README.md # benches/note_decryption.rs # rust-toolchain # src/builder.rs # src/bundle.rs # src/note_encryption.rs # src/value.rs # tests/zsa.rs

PaulLaux

Great work, approved pending two fixes.

PaulLaux · 2022-12-07T11:16:26Z

.circleci/config.yml

    # See: https://circleci.com/docs/2.0/configuration-reference/#docker-machine-macos-windows-executor
    docker:
-      - image: cimg/rust:1.59.0
+      - image: cimg/rust:1.61


probably need to be 1.61.0, in the spirit of unification.

That's what I got from your rebased branch, so I've changed all 1.61.0 that I've introduced to this :) I can change it back

src/builder.rs

PaulLaux · 2022-12-07T11:27:37Z

src/value.rs

        )
    }
+
+    pub(crate) fn into<V: TryFrom<i64>>(self) -> Result<V, Error> {


Change to try_from as discussed in builder.rs:442

This reverts commit 26bfce5.

PaulLaux and others added 28 commits July 18, 2022 12:03

Circleci project setup (#1)

33a205b

* Added .circleci/config.yml

issuer keys implementation (#5)

71565ee

Implements the issuer keys as IssuerAuthorizingKey -> isk IssuerVerifyingKey -> ik Test vectors generated with zcash_test_vectors repo

Added NoteType to Notes (#2)

5ae5107

* Added NoteType to Notes * Added NoteType to value commitment derivation

Issuance (#12)

b90f88d

- added IssueBundle and IssueAction - added a builder for IssueBundle - added verify_issue_bundle() for consensus verification. - unit tests.

E2E tests for issuance (#20)

afaad60

added tests in `tests/zsa.rs`

disabled split notes (#22)

081b01b

* disabled split notes and proof check for zsa transfer

Review fixes (#23)

22377f2

* fixes and suggestions * changed "issuer" to "issuance" as per zcash#356 (comment) * terminology fixes * updated naming

Review fixes2 (#24)

4f9b589

* rename 2 note_type -> asset as per zcash#356 (comment) * added a dedicated type for "IssuanceAuth" * disabled codecov github action due to bad behavior. * extracted "is_asset_desc_of_valid_size()" into asset_id.rs

verify_issue_bundle() cleanup (#25)

4e23faf

* improved `verify_issue_bundle()`

WIP

2ed26d2

Fix bvk-bsk consistency test

dfa9a53

E2E test draft

e1d1dd7

PR preview

99789fd

Rust toolchain 1.61.0

675c1da

Rust toolchain 1.61.0 EVERYWHERE

fef34e8

Not allow to burn native assets

7b5c32d

Fix burnt assets type

d282307

PR comments part 1

880ec64

TODO added

bb4bbba

PR fixes

cef9963

BVK building code deduplication

12e09da

PR fixes 2

c64af45

Generic addition for value sum

392478c

Clippy

e91596b

Unify Rust version

e3deb03

PaulLaux approved these changes Dec 7, 2022

View reviewed changes

Replace into with TryFrom trait bound

26bfce5

alexeykoren added 4 commits December 7, 2022 13:34

1.61.0

be8333c

Revert "Replace into with TryFrom trait bound"

927cf40

This reverts commit 26bfce5.

proptest-regressions/*.txt

313e5b2

Minor type fix

fbb65a5

alexeykoren merged commit d8f3563 into zsa1 Dec 7, 2022

PaulLaux changed the title ~~ZSA burn functionality 2~~ ZSA burn functionality Dec 8, 2022

This was referenced Dec 8, 2022

Issuance for ZSA zcash/orchard#364

Closed

ZSA burn functionality #28

Closed

This was referenced Jan 26, 2023

Zsa1 diff, for reference only #7

Draft

OrchardZSA reference implementation zcash/orchard#372

Closed

dmidem mentioned this pull request May 7, 2024

Update to upstream (zcash/main v0.8.0) #103

Merged

PaulLaux mentioned this pull request May 14, 2025

enable webassembly support #164

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ZSA burn functionality#35

ZSA burn functionality#35
alexeykoren merged 33 commits intozsa1from
zsa1-burn

alexeykoren commented Dec 7, 2022 •

edited by PaulLaux

Loading

Uh oh!

PaulLaux left a comment •

edited

Loading

Uh oh!

PaulLaux Dec 7, 2022

Uh oh!

alexeykoren Dec 7, 2022

Uh oh!

Uh oh!

PaulLaux Dec 7, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

alexeykoren commented Dec 7, 2022 • edited by PaulLaux Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

PaulLaux left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

PaulLaux Dec 7, 2022

Choose a reason for hiding this comment

Uh oh!

alexeykoren Dec 7, 2022

Choose a reason for hiding this comment

Uh oh!

Uh oh!

PaulLaux Dec 7, 2022

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

alexeykoren commented Dec 7, 2022 •

edited by PaulLaux

Loading

PaulLaux left a comment •

edited

Loading