Use different random nullifiers in dummy notes#39
Merged
alexeykoren merged 4 commits intozsa1from Dec 23, 2022
Merged
Conversation
PaulLaux
approved these changes
Dec 22, 2022
Collaborator
PaulLaux
left a comment
PaulLaux
left a comment
There was a problem hiding this comment.
approved with minor comment.
Comment on lines
-406
to
-409
| let dummy_spend = SpendInfo::dummy(asset, &mut rng); | ||
|
|
||
| // Extend the spends and recipients with dummy values. | ||
| spends.extend(iter::repeat_with(|| dummy_spend.clone()).take(num_actions - num_spends)); |
Collaborator
There was a problem hiding this comment.
Do not remove those lines but add them to the comment starting in line 400.
Will will need to uncomment everything at later time to properly incorporate the split_note functionality.
Collaborator
|
The intention is to use the same |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apparently client doesn't like cloned dummy spends, because they have same nullifier