Circuit: Update note_commit to take into account asset#56
Merged
ConstanceBeguier merged 28 commits intozsa1from May 23, 2023
Merged
Circuit: Update note_commit to take into account asset#56ConstanceBeguier merged 28 commits intozsa1from
ConstanceBeguier merged 28 commits intozsa1from
Conversation
addc182 to
f3217ed
Compare
34a4b71 to
004881d
Compare
PaulLaux
reviewed
May 10, 2023
6a6eaf1 to
b24de51
Compare
Collaborator
Author
|
I just rebased on zsa1 branch |
PaulLaux
reviewed
May 16, 2023
Collaborator
PaulLaux
left a comment
There was a problem hiding this comment.
added some minor comments. As discussed, let's wait for today's meeting before the final approve.
|
|
||
| region.assign_advice(|| "out y", self.config.out, 0, || out_val) | ||
| }, | ||
| )?; |
Collaborator
There was a problem hiding this comment.
I don't like the duplication between x_cell and y_cell but don't see an easy way to remove it.
b24de51 to
4dda8eb
Compare
Collaborator
Author
|
I just rebased on zsa1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the circuit, we update note_commit to take into account asset.
Previously, note_commit returns cm = hash(Q_ZEC, msg) + [rcm]R.
Now, note_commit returns
We now evaluate note_commit with the following steps
= hash_zsa otherwise
The following modifications are required to update note_commit:
Warning: we increased the size of the Orchard circuit !