Skip to content

Exclude non-native assets from value_balance#120

Merged
alexeykoren merged 2 commits intozsa1from
zsa-value-balance
Nov 13, 2024
Merged

Exclude non-native assets from value_balance#120
alexeykoren merged 2 commits intozsa1from
zsa-value-balance

Conversation

@alexeykoren
Copy link

Exclude non-native assets from value_balance

@alexeykoren alexeykoren requested a review from PaulLaux November 12, 2024 16:39
@what-the-diff
Copy link

what-the-diff bot commented Nov 12, 2024

PR Summary

  • Updated Documentation
    The instructions in the documentation have been clarified to specify "ZEC" when talking about the bundle value. This helps better understand the context and purpose of the bundle value.
  • Added Filtering in Value Balance Calculation
    For calculating the value balance, we have added a new measure which only includes native assets. This modification helps in achieving more accuracy by taking into account only those assets which directly belong to the platform.

Copy link
Collaborator

@PaulLaux PaulLaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix,
Approved with minor comments

@alexeykoren alexeykoren merged commit 25020f8 into zsa1 Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants