Skip to content

Update with new version of Sinsemilla#159

Merged
ConstanceBeguier merged 2 commits intozsa1from
sinsemilla_review
May 1, 2025
Merged

Update with new version of Sinsemilla#159
ConstanceBeguier merged 2 commits intozsa1from
sinsemilla_review

Conversation

@ConstanceBeguier
Copy link
Collaborator

@ConstanceBeguier ConstanceBeguier commented Apr 22, 2025

  • Direct evaluation of note commitments (outside the circuit)
  • Rename new_with_personalization by new_with_separate_domains

@ConstanceBeguier ConstanceBeguier changed the title Direct note commitment evaluation (outside the circuit) Update with new version of Sinsemilla Apr 22, 2025
@PaulLaux PaulLaux requested a review from Copilot April 30, 2025 09:54
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the note commitment evaluation to use direct evaluation of note commitments with separate domains, and renames the function from new_with_personalization to new_with_separate_domains. Key changes include:

  • Evaluating the ZEC and ZSA note commitments using updated sinsemilla APIs.
  • Renaming function calls to better reflect the separation of domains.
  • Updating the sinsemilla dependency in Cargo.toml to track the "zsa1" branch instead of a specific revision.

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
src/note/commitment.rs Updated note commitment evaluation logic with new domains
Cargo.toml Updated the sinsemilla dependency to branch "zsa1"
Comments suppressed due to low confidence (1)

src/note/commitment.rs:147

  • The removal of the test module from this file reduces test coverage for the note commitment functionality; please ensure these tests are migrated or provided elsewhere to verify the updated commitment behavior.
impl Eq for ExtractedNoteCommitment {}

@ConstanceBeguier
Copy link
Collaborator Author

I just rebased on zsa1 branch

@ConstanceBeguier ConstanceBeguier merged commit 0a61d36 into zsa1 May 1, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants