Update with new version of Sinsemilla#159
Merged
ConstanceBeguier merged 2 commits intozsa1from May 1, 2025
Merged
Conversation
PaulLaux
approved these changes
Apr 30, 2025
There was a problem hiding this comment.
Pull Request Overview
This PR updates the note commitment evaluation to use direct evaluation of note commitments with separate domains, and renames the function from new_with_personalization to new_with_separate_domains. Key changes include:
- Evaluating the ZEC and ZSA note commitments using updated sinsemilla APIs.
- Renaming function calls to better reflect the separation of domains.
- Updating the sinsemilla dependency in Cargo.toml to track the "zsa1" branch instead of a specific revision.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/note/commitment.rs | Updated note commitment evaluation logic with new domains |
| Cargo.toml | Updated the sinsemilla dependency to branch "zsa1" |
Comments suppressed due to low confidence (1)
src/note/commitment.rs:147
- The removal of the test module from this file reduces test coverage for the note commitment functionality; please ensure these tests are migrated or provided elsewhere to verify the updated commitment behavior.
impl Eq for ExtractedNoteCommitment {}
828b041 to
46b7596
Compare
Collaborator
Author
|
I just rebased on zsa1 branch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.