Skip to content

Updates to TXID Digest and Authorizing Data Commitment#66

Merged
vivek-arte merged 2 commits intozsa1from
update_txid_impl
Jun 13, 2023
Merged

Updates to TXID Digest and Authorizing Data Commitment#66
vivek-arte merged 2 commits intozsa1from
update_txid_impl

Conversation

@vivek-arte
Copy link

This PR updates the computation of the transaction digest and authorizing data commitment for the issue bundle to be in line with the specification in ZIP 227.

@what-the-diff
Copy link

what-the-diff bot commented Jun 1, 2023

PR Summary

  • Updated hash_issue_bundle function
    The function now includes the asset description in its computation for more accurate calculations.
  • New function: hash_issue_bundle_empty
    This new function allows for computing commitments for transactions without shielded inputs or outputs, based on ZIP-227 guidelines, providing a uniform way to handle transaction IDs.

Copy link
Collaborator

@PaulLaux PaulLaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with some comments pending,

@vivek-arte vivek-arte merged commit 950b806 into zsa1 Jun 13, 2023
vivek-arte added a commit to QED-it/zips that referenced this pull request Jun 29, 2023
…mentation (#29)

This makes the changes in ZIP 227 based on [this
comment](QED-it/orchard#66 (comment)).
PaulLaux pushed a commit to QED-it/zips that referenced this pull request Oct 4, 2023
…mentation (#29)

This makes the changes in ZIP 227 based on [this
comment](QED-it/orchard#66 (comment)).
daira pushed a commit to daira/zips that referenced this pull request Feb 7, 2024
…mentation (zcash#29)

This makes the changes in ZIP 227 based on [this
comment](QED-it/orchard#66 (comment)).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants