Merged
Conversation
ConstanceBeguier
force-pushed
the
global_padding_for_bundle
branch
from
6412e32 to
5dd71c4
Compare
ConstanceBeguier
changed the base branch from
zsa1
to
no_split_note_for_native_asset
ConstanceBeguier
force-pushed
the
global_padding_for_bundle
branch
from
b0ee040 to
834592e
Compare
ConstanceBeguier
force-pushed
the
global_padding_for_bundle
branch
from
0a35949 to
a0ef34b
Compare
ConstanceBeguier
changed the base branch from
no_split_note_for_native_asset
to
zsa1
PaulLaux
approved these changes
Jun 6, 2023
Collaborator
PaulLaux
left a comment
PaulLaux
left a comment
There was a problem hiding this comment.
approved with some comments.
This reverts commit 1a5efa2.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Each bundle must contain at least two actions for privacy concerns.
Previously, we pad bundle to have at least two actions per asset.
Now, we pad bundle globally, and add dummy/split actions to have at least two actions per bundle.