Do not create split notes with native asset#65
Merged
ConstanceBeguier merged 9 commits intozsa1from Jun 6, 2023
Merged
Conversation
ConstanceBeguier
changed the title
ConstanceBeguier
changed the title
ConstanceBeguier
changed the title
PaulLaux
reviewed
May 29, 2023
ConstanceBeguier
force-pushed
the
no_split_note_for_native_asset
branch
from
7c0e9ed to
2371d12
Compare
ConstanceBeguier
force-pushed
the
no_split_note_for_native_asset
branch
from
16fa4b0 to
591a70d
Compare
PaulLaux
approved these changes
Jun 5, 2023
Collaborator
PaulLaux
left a comment
PaulLaux
left a comment
There was a problem hiding this comment.
Approved with some comments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Due to privacy considerations, we might incorporate dummy or split notes while generating a bundle.
However, to maintain consistency with the previous version, we choose not to include split notes for native asset.
In addition, we use a new dummy/split notes for each extend in order to have different nullifiers.