Skip to content

Update to orchard_auth_digest computation#134

Merged
vivek-arte merged 5 commits intozsa1from
update_orchard_auth_commitment
Jan 18, 2025
Merged

Update to orchard_auth_digest computation#134
vivek-arte merged 5 commits intozsa1from
update_orchard_auth_commitment

Conversation

@vivek-arte
Copy link

This PR updates the code to perform the computation differently for OrchardVanilla and OrchardZSA, similar to the txid_data changes

…ntly for OrchardVanilla and OrchardZSA, similar to the txid_data changes
@QED-it QED-it deleted a comment from what-the-diff bot Jan 14, 2025
Copy link
Collaborator

@ConstanceBeguier ConstanceBeguier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please verify the hash by comparing it to a constant value. Generate the constant hash for Orchard using the upstream Orchard crate. This will help ensure that the original commitment remains intact and has not been altered.

Copy link
Collaborator

@PaulLaux PaulLaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some minor comments

Copy link
Collaborator

@PaulLaux PaulLaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice

@vivek-arte vivek-arte merged commit 3dbdbc5 into zsa1 Jan 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants