Conversation
* Added .circleci/config.yml
* Added .circleci/config.yml
Implements the issuer keys as
IssuerAuthorizingKey -> isk
IssuerVerifyingKey -> ik
Test vectors generated with zcash_test_vectors repo
* Added NoteType to Notes * Added NoteType to value commitment derivation
Unit and property tests for issue bundle Commitments for issuance
PaulLaux
reviewed
Oct 3, 2022
PaulLaux
reviewed
Oct 3, 2022
PaulLaux
reviewed
Oct 3, 2022
PaulLaux
reviewed
Oct 3, 2022
PaulLaux
reviewed
Oct 12, 2022
Collaborator
PaulLaux
left a comment
PaulLaux
left a comment
There was a problem hiding this comment.
Overall good work, added comments required to finalize.
| fn verify_bundle(bundle: &Bundle<Authorized, i64>, vk: &VerifyingKey) { | ||
| assert!(matches!(bundle.verify_proof(vk), Ok(()))); | ||
| pub fn verify_bundle(bundle: &Bundle<Authorized, i64>, _vk: &VerifyingKey) { | ||
| // TODO uncomment when circuit can work with split flag - assert!(matches!(bundle.verify_proof(vk), Ok(()))); |
Collaborator
There was a problem hiding this comment.
This will prevent proof verification for non ZSA tests as well.
Probably should add a boolean flag for conditional verification and activate for builder.rs test.
PaulLaux
approved these changes
Oct 20, 2022
vivek-arte
pushed a commit
that referenced
this pull request
Nov 24, 2022
added tests in `tests/zsa.rs`
PaulLaux
pushed a commit
that referenced
this pull request
Dec 6, 2022
added tests in `tests/zsa.rs`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tests for ZSA issuance and transfer