Skip to content

Fix IssueBundle and IssueAction structures#70

Merged
ConstanceBeguier merged 9 commits intozsa1from
fix_issue_bundle
Jun 12, 2023
Merged

Fix IssueBundle and IssueAction structures#70
ConstanceBeguier merged 9 commits intozsa1from
fix_issue_bundle

Conversation

@ConstanceBeguier
Copy link
Collaborator

@ConstanceBeguier ConstanceBeguier commented Jun 8, 2023

The vector of issue actions in an IssueBundle must not be empty.
The vector of notes in an IssueAction could be empty when finalize is set to true.

We could add some actions in an IssueAction even if finalize is set to true.
Only the next block is affected by the finalize flag, not the current block.

@what-the-diff
Copy link

what-the-diff bot commented Jun 8, 2023

PR Summary

  • Enhanced issue_zsa_notes() function
    The function now accepts an asset description as a parameter for better flexibility.

  • New unauthorized_asset variable and changes to IssueBundle::new() method
    The new variable stores results of an updated method that takes an additional argument, improving the creation of issue bundles.

  • Removal of 'assert!' and improved error handling
    Assertions were replaced with 'if let Err(_err)' statements for more graceful failure handling during tests, preventing crashes and improving overall stability.

@ConstanceBeguier ConstanceBeguier requested a review from PaulLaux June 8, 2023 17:36
Copy link
Collaborator

@PaulLaux PaulLaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added some comments.

@ConstanceBeguier ConstanceBeguier merged commit 7ad2bac into zsa1 Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants