WIP: Backports for 1.0.2 #29444

KristofferC · 2018-09-30T17:04:45Z

Backported PRs:

correct the docs of Nothing #29210 - correct the docs of Nothing
fix digits(n::Unsigned) with neg base for n > typemax(n)÷2 #29205 - fix digits(n::Unsigned) with neg base for n > typemax(n)÷2
Make using LinearAlgebra explicit #29188 - Make using LinearAlgebra explicit
fix reinterpret(Char, ::UInt32) for "unnatural" values (fix #29181) #29192 - fix reinterpret(Char, ::UInt32) for "unnatural" values (fix Char reinterpret is (kind of) broken #29181)
fix awkward phrasing in parallel-computing.md #29233 - fix awkward phrasing in parallel-computing.md
Base.TCPServer --> Sockets.TCPServer #29230 - Base.TCPServer --> Sockets.TCPServer
Changed one identifier in one example #29279 - Changed one identifier in one example
Minor cleanup of noteworthy differences #29245 - Minor cleanup of noteworthy differences
Improve description of Julia keywords #29229 - Improve description of Julia keywords
fix minor typo in parallel-computing.md #29232 - fix minor typo in parallel-computing.md
Fix a typo in docs #29299 - Fix a typo in docs
typo fix in parallel-computing.md #29319 - typo fix in parallel-computing.md
fix #29306, teach effect_free that GotoIfNot with non-Bool can throw #29322 - fix Miscompilation of invalid conditionals when both branches yield the same value #29306, teach effect_free that GotoIfNot with non-Bool can throw
Improve noteworthy differences from R on ismissing #29332 - Improve noteworthy differences from R on ismissing
Minor docs correction for maxintfloat. #29301 - Minor docs correction for maxintfloat.
fix bug in parsing extended colon-like operators #29314 - fix bug in parsing extended colon-like operators
Add missing test dependencies to SparseArrays Project.toml #29354 - Add missing test dependencies to SparseArrays Project.toml
Some misisng paren and xrefs #29351 - Some misisng paren and xrefs
Backticks and xrefs #29349 - Backticks and xrefs
avoid conversion from Char to String to Symbol in some LinearAlgebra routines #29352 - avoid conversion from Char to String to Symbol in some LinearAlgebra routines
Minor English fixes #29338 - Minor English fixes
Fix: Complex SubArray times real Matrix #29246 - Fix: Complex SubArray times real Matrix
fix #29326, return type lowering interfering with closure optimization #29346 - fix Combo of begin block and return type annotation breaks closure inference #29326, return type lowering interfering with closure optimization
always obey inline declarations if the calling signature is concrete #29258 - always obey inline declarations if the calling signature is concrete
fix crash when interpreting optimized top-level expressions #29217 - fix crash when interpreting optimized top-level expressions
Minor English fixes/improvements #29391 - Minor English fixes/improvements
Remove docstring relicts of findlast/findprev with a regex #29398 - Remove docstring relicts of findlast/findprev with a regex
doc: fix not-true-anymore example with promote_rule #29416 - doc: fix not-true-anymore example with promote_rule
improve findnext/findprev docstring for strings #29415 - improve findnext/findprev docstring for strings
fix #29208, incorrect Union{} result from type intersection #29380 - fix another bug which crashes julia 1.0 and latest nightly 1.1.0 #29208, incorrect Union{} result from type intersection
fix sizeof(str::AbstractString) docstring #29414 - fix sizeof(str::AbstractString) docstring
Change from parametric T signature to Int32 in _ldexp_exp #29401 - Change from parametric T signature to Int32 in _ldexp_exp
fix #20872, handle UnionAll types in which #29419 - fix Reflection functions should handle UnionAll #20872, handle UnionAll types in which
Fix sentence fragment #29431 - Fix sentence fragment
check return from jl_restore_incremental correctly #29325 - check return from jl_restore_incremental correctly
Some improvements to variables and scoping manual #29376 - Some improvements to variables and scoping manual
If stdio is not available, be permissive and do not exit #29374 - If stdio is not available, be permissive and do not exit
Improved English and egs #29281 - Improved English and egs
fix #29454: better example for mutable struct #29475 - fix String is not a good example of a mutable struct #29454: better example for mutable struct
tiny formatting fix on docs #29463 - tiny formatting fix on docs
Two small build system improvements #29486 - Two small build system improvements
Upgrade to new Documenter #29470 - Upgrade to new Documenter
Correct language in documentation #29502 - Correct language in documentation
fix #29468, bug in intersection of different-length vararg tuples #29487 - fix Illegal instruction in Julia 1.0.0/1.1.0 (but not in 0.7.0) #29468, bug in intersection of different-length vararg tuples
Fix #29451: parse(Int, s::AbstractString) when ncodeunits(s) > lastindex(s) #29465 - Fix parseint_preamble bounds check fails for AbstractString #29451: parse(Int, s::AbstractString) when ncodeunits(s) > lastindex(s)
Add --project option to man page #29497 - Add --project option to man page
English fixes #29336 - English fixes
Minor English fixes #29337 - Minor English fixes
REPL: really fix #29347, searching a string not in history #29412 - REPL: really fix REPL: BoundsError in history search #29347, searching a string not in history
REPL: make paste work in search mode #29373 - REPL: make paste work in search mode
initdefs: Typo #29482 - initdefs: Typo
REPL: show "failed" when i-search fails, like in readline #29413 - REPL: show "failed" when i-search fails, like in readline
[ci skip] Remove mention of Julia version #29519 - [ci skip] Remove mention of Julia version
[ci skip] Fix a typo in doc #29521 - [ci skip] Fix a typo in doc
Update performance-tips.md #29543 - Update performance-tips.md
Escape jl_atexit_hook first _ #29485 - Escape jl_atexit_hook first _
flatten empty tuple - fix #29112 #29548 - flatten empty tuple - fix Allow Iterators.flatten for empty tuple #29112
basedocs: add 'See also' for getproperty and setproperty! #29570 - basedocs: add 'See also' for getproperty and setproperty!
Fixing abs for Rational{<:Unsigned} #29561 - Fixing abs for Rational{<:Unsigned}
Fix quantile doctest formatting #29573 - Fix quantile doctest formatting
Fix a typo: replacing 'temporarly' for 'temporarily' #29627 - Fix a typo: replacing 'temporarly' for 'temporarily'
Document Dates.value #29591 - Document Dates.value
fix an indent of Mmap.mmap #29641 - fix an indent of Mmap.mmap
Workaround subarray test failure due to associativity. #29386 - Workaround subarray test failure due to associativity.
Fix typo in arrays.md #29648 - Fix typo in arrays.md
fix #29644: getproperty of Tridiagonal{SparseVector} #29646 - fix Error displaying L factor of Tridiagonal matrix #29644: getproperty of Tridiagonal{SparseVector}
improve performance for ascii(::String) #29609 - improve performance for ascii(::String)
fix #29662: missing import from Base.Printf to Printf stdlib. #29663 - fix printf type field e fails for large numbers if both width and precision fields are defined #29662: missing import from Base.Printf to Printf stdlib.
propgate inbounds to substring and use it in split #29557 - propgate inbounds to substring and use it in split
Use a stable inverse for Tridiagonal and SymTridiagonal #29667 - Use a stable inverse for Tridiagonal and SymTridiagonal
Don't splat a number in ReshapedArray #29677 - Don't splat a number in ReshapedArray
Adjust doc test for \ to avoid rounding #29689 - Adjust doc test for \ to avoid rounding
add inbounds to some more substrings #29680 - add inbounds to some more substrings
fix #29711: triu! for m > n #29712 - fix [BUG] triu returns wrong matrix when M<N and k<0 #29711: triu! for m > n
Fix jldoctest example in mapreduce(...) #29604 - Fix jldoctest example in mapreduce(...)
Uniform scaling cat with zero dimensions #29457 - Uniform scaling cat with zero dimensions
improve performance for sorting columns in sparse matrix (thereby improving sparse matmul) #29682 - improve performance for sorting columns in sparse matrix (thereby improving sparse matmul)
Mention that the = part of --project is optional. Add to regular Julia docs as well. #29731 - Mention that the = part of --project is optional. Add to regular Julia docs as well.
Fix bug in nullspace when the matrix is empty #29725 - Fix bug in nullspace when the matrix is empty
convert Integer in Cholesky constructors to BlasInt #29732 - convert Integer in Cholesky constructors to BlasInt
Fix hashing of Dates.Time. Fixes #29480 #29742 - Fix hashing of Dates.Time. Fixes Using Dates.Time as dictionary keys #29480
punctuation error #29763 - punctuation error
improve performance for sparse matrix vector indexing #29696 - improve performance for sparse matrix vector indexing
fix #29718, union field alignment #29722 - fix Unreachable reached with NamedTuple of StaticVector #29718, union field alignment
speed up logical indexing by bitarray #29746 - speed up logical indexing by bitarray
adding _small_enough for diagonal so that fill! works #29780 - adding _small_enough for diagonal so that fill! works
Fix for the markdown table in getting-started.md #29797 - Fix for the markdown table in getting-started.md
clarify pinv documentation #29793 - clarify pinv documentation
Created an actual table [Manual,Scope of Variables] #29789 - Created an actual table [Manual,Scope of Variables]
make tables on Interfaces pages more consistent #29703 - make tables on Interfaces pages more consistent
Fix out-of-tree build of docs, fix #29757. #29760 - Fix out-of-tree build of docs, fix make docs doesn't copy _build/html for out of tree builds #29757.
Download Pkg from GitHub releases. #29615 - Download Pkg from GitHub releases.
Use Documenter release instead of master. #29830 - Use Documenter release instead of master.
Fix CInt to Cint in docs #29834 - Fix CInt to Cint in docs
help type inference for logical indexing #29633 - help type inference for logical indexing
Make pinv work for Adjoint #29837 - Make pinv work for Adjoint
fix reinterpret error message string #29844 - fix reinterpret error message string
Reduce allocation in flatten #29786 - Reduce allocation in flatten
Use require(pkgid, ...) instead of relative require #29770 - Use require(pkgid, ...) instead of relative require
fix #29528, specificity transitivity error in DiffEqBase #29539 - fix "Assertion `!jl_subtype((jl_value_t*)sig, (jl_value_t*)type)' failed" when compiling DiffEqBase using julia-debug #29528, specificity transitivity error in DiffEqBase
fix eval world updates #29765 - fix eval world updates
egal_tfunc bugfix #29838 - egal_tfunc bugfix
Reinstate statically computed log event ids #29878 - Reinstate statically computed log event ids
Fix isvalid for 3-byte overlong encoded UTF-8 sequences #29908 - Fix isvalid for 3-byte overlong encoded UTF-8 sequences

Non-merged PRs with backport label:

Prepend a version number too in source tarballs #29738 - Prepend a version number too in source tarballs
fixes for the runtime (interpreted intrinsics) #29721 - fixes for the runtime (interpreted intrinsics)
Update arrays.md for element-wise assignment #29167 - Update arrays.md for element-wise assignment
Initializer the union selector of undefined upsilon nodes #29158 - Initializer the union selector of undefined upsilon nodes

(cherry picked from commit 5dda994)

Alternative based on #29187 Tests from rforquet's PR linked above. (cherry picked from commit 16516b5)

Ref. https://discourse.julialang.org/t/error-undefvarerror-eigvecs-not-defined/14923/2?u=stillyslalom (cherry picked from commit 2c15430)

(cherry picked from commit 157a6d1)

(cherry picked from commit abe38f1)

The example used identifier `x` for two different purposes. While this isn't a problem for Julia, it makes humans have to read much more carefully. For examples I think it is much clearer to use different identifiers for different purposes. (cherry picked from commit 6354405)

Minor language fixes. Two more significant changes are: * it is recommended to use `===` to compare to `nothing` * `=` is not a binary operator (cherry picked from commit 27de698)

(cherry picked from commit b777030)

(cherry picked from commit ce64546)

I spotted a typo when reviewing the merge. (cherry picked from commit 338cf0d)

(cherry picked from commit 60e6794)

…29322) (cherry picked from commit a854139)

The R function is called is.na, and automatically works element-wise. (cherry picked from commit 8484f97)

Fixes #29297, see discussion there. (cherry picked from commit 64a4f18)

(cherry picked from commit 0b5e21c)

(cherry picked from commit c37f4aa)

…routines (#29352) (cherry picked from commit 993e7d7)

(cherry picked from commit 94aa39b)

* gemm_wrapper! -> mul! (#29224) * testing for #29224 * code review update: More tests * Complex times real reinterpret trick fix for vectors and transposed matrices (cherry picked from commit 82503cd)

#29346) (cherry picked from commit 48f5bb3)

…29258) This implements the suggestion in #27857 (comment) (cherry picked from commit 8d6c1ce)

(cherry picked from commit 493068b)

(cherry picked from commit 47668c8)

(cherry picked from commit ba41f69)

(cherry picked from commit bc34c64)

also fixes #29357 (cherry picked from commit 6794778)

(cherry picked from commit e1f42b1)

__ldexp_exp(f) requires the second argument to be an Int32, so we might as well hard-code that here. It also seems that the old specification is actually not valid, or might have unexpected results, so we should just go with Int32, see #29400 . (cherry picked from commit 75f798f)

(cherry picked from commit f42f7b7)

Move whereas clause into subordinate position to avoid sentence fragment. (cherry picked from commit 8907aff)

(cherry picked from commit be1ae20)

(cherry picked from commit 82c4fce)

(cherry picked from commit b72fc4c)

* propgate inbounds to substring and use it in split * remove Base prefix (cherry picked from commit 18b9fc2)

(cherry picked from commit 5c2e0b5)

(cherry picked from commit 2885b62)

(cherry picked from commit 0e023d0)

* speed up logical indexing by bitarray * changed inbounds / OOB behavior to match array iterators switched spelling of _blsr * Update base/multidimensional.jl Co-Authored-By: chethega <[email protected]> (cherry picked from commit 44f2563)

(cherry picked from commit aa72f72)

* Remove Pkg from the JuliaLang/julia repo. * Use git-external to install Pkg during build. (cherry picked from commit 1717adb)

These were scattered about conservatively, and not always in the right places. Here we narrow them to apply more specifically, and remove several that should not be observable. fix #29761 (cherry picked from commit 715e0eb, PR #29765)

Oops. fixes #29836, and adds explicit test coverage (cherry picked from commit e270fbb)

This was broken when `findfirst` was deprecated in 9bdf07f. (cherry picked from commit 3aeccec)

Fixes #29723 (cherry picked from commit a472bc7)

(cherry picked from commit 5e9feb4)

(cherry picked from commit 07ea302)

Co-authored-by: Jameson Nash <[email protected]> (cherry picked from commit 6ae6551)

* fix bug and add tests * Reinstate statically computed log record ids Log ids are meant to identify the location of the message in the source code and must be computed at compile time. fix #28786, fix #28400; closes #29355. * Clarify documentation regarding log record `id` (cherry picked from commit 51683c4)

(cherry picked from commit 1bbea22)

KristofferC · 2018-11-02T20:45:42Z

Removed #29726 and added #29908 (since it was requested). @ararslan think we are ready for another round.

ararslan · 2018-11-03T06:29:23Z

PkgEval says we're all good now. 😎

fredrikekre · 2018-11-03T07:48:34Z

Merge and announce a short testing period like last time?

KristofferC · 2018-11-03T19:46:19Z

Sounds good to me.

ararslan · 2018-11-03T19:47:03Z

Thanks for all of your awesome work here, Kristoffer!

ararslan · 2018-11-03T20:02:26Z

Testing period announcement: https://discourse.julialang.org/t/julia-1-0-2-testing-period/17121?u=ararslan

githubtomtom and others added 30 commits September 30, 2018 12:58

correct the docs of Nothing (#29210)

7a30fbd

(cherry picked from commit 5dda994)

fix digits(n::Unsigned) with neg base for n > typemax(n)÷2 (#29205)

bba596f

Alternative based on #29187 Tests from rforquet's PR linked above. (cherry picked from commit 16516b5)

Make using LinearAlgebra explicit (#29188)

f664f26

Ref. https://discourse.julialang.org/t/error-undefvarerror-eigvecs-not-defined/14923/2?u=stillyslalom (cherry picked from commit 2c15430)

fix awkward phrasing in parallel-computing.md

a7584a8

(cherry picked from commit 157a6d1)

Base.TCPServer --> Sockets.TCPServer (#29230)

038b9bb

(cherry picked from commit abe38f1)

Minor cleanup of noteworthy differences (#29245)

20b3cb5

Minor language fixes. Two more significant changes are: * it is recommended to use `===` to compare to `nothing` * `=` is not a binary operator (cherry picked from commit 27de698)

Improve description of Julia keywords (#29229)

6c82eef

(cherry picked from commit b777030)

fix minor typo in parallel-computing.md (#29232)

c5f3adc

(cherry picked from commit ce64546)

Fix a typo in docs (#29299)

829a976

I spotted a typo when reviewing the merge. (cherry picked from commit 338cf0d)

typo fix in parallel-computing.md (#29319)

08d8221

(cherry picked from commit 60e6794)

fix #29306, teach effect_free that GotoIfNot with non-Bool can throw (#…

e931f98

…29322) (cherry picked from commit a854139)

Improve noteworthy differences from R on ismissing (#29332)

10d8327

The R function is called is.na, and automatically works element-wise. (cherry picked from commit 8484f97)

Minor docs correction for maxintfloat. (#29301)

fbd841e

Fixes #29297, see discussion there. (cherry picked from commit 64a4f18)

Some misisng paren and xrefs (#29351)

639032c

(cherry picked from commit 0b5e21c)

Backticks and xrefs (#29349)

d0710c7

(cherry picked from commit c37f4aa)

avoid conversion from Char to String to Symbol in some LinearAlgebra …

ea37169

…routines (#29352) (cherry picked from commit 993e7d7)

Minor English fixes in constructors.md (#29338)

c5b32ae

(cherry picked from commit 94aa39b)

Fix: Complex SubArray times real Matrix (#29246)

5addb28

* gemm_wrapper! -> mul! (#29224) * testing for #29224 * code review update: More tests * Complex times real reinterpret trick fix for vectors and transposed matrices (cherry picked from commit 82503cd)

fix #29326, return type lowering interfering with closure optimization (

69e8fc6

#29346) (cherry picked from commit 48f5bb3)

always obey inline declarations if the calling signature is concrete (#…

2f9e279

…29258) This implements the suggestion in #27857 (comment) (cherry picked from commit 8d6c1ce)

fix crash when interpreting optimized top-level expressions (#29217)

80747f6

(cherry picked from commit 493068b)

Remove docstring relicts of findlast/findprev for regex (#29398)

d67c205

(cherry picked from commit 47668c8)

doc: fix not-true-anymore example with promote_rule (#29416)

b029b7b

(cherry picked from commit ba41f69)

improve findnext/findprev docstring for strings (#29415)

63384f3

(cherry picked from commit bc34c64)

fix #29208, incorrect Union{} result from type intersection (#29380)

8cc9136

also fixes #29357 (cherry picked from commit 6794778)

fix sizeof(str::AbstractString) docstring (#29414)

87ef685

(cherry picked from commit e1f42b1)

fix #20872, handle UnionAll types in which (#29419)

2493934

(cherry picked from commit f42f7b7)

Fix sentence fragment (#29431)

bcc39e2

Move whereas clause into subordinate position to avoid sentence fragment. (cherry picked from commit 8907aff)

fredrikekre and others added 19 commits November 2, 2018 16:43

Use Documenter release instead of master. (#29830)

5864e7e

(cherry picked from commit be1ae20)

Fix CInt to Cint in docs (#29834)

17a45cc

(cherry picked from commit 82c4fce)

improve performance for ascii (#29609)

df5618b

(cherry picked from commit b72fc4c)

propgate inbounds to substring and use it in split (#29557)

13b3983

* propgate inbounds to substring and use it in split * remove Base prefix (cherry picked from commit 18b9fc2)

add inbounds to some more substrings (#29680)

3dcb8b2

(cherry picked from commit 5c2e0b5)

improve performance for sorting columns in sparse matrix (#29682)

8647b96

(cherry picked from commit 2885b62)

improve performance for sparse matrix vector indexing (#29696)

d58ee9f

(cherry picked from commit 0e023d0)

help type inference for logical indexing (#29633)

14be38f

(cherry picked from commit aa72f72)

Download Pkg from GitHub releases. (#29615)

6b11812

* Remove Pkg from the JuliaLang/julia repo. * Use git-external to install Pkg during build. (cherry picked from commit 1717adb)

fix eval world updates

87d94ea

These were scattered about conservatively, and not always in the right places. Here we narrow them to apply more specifically, and remove several that should not be observable. fix #29761 (cherry picked from commit 715e0eb, PR #29765)

inference: fix egal_tfunc for Conditional

31234c1

Oops. fixes #29836, and adds explicit test coverage (cherry picked from commit e270fbb)

inference: fix efficiency of tfunc key lookup

3df1997

This was broken when `findfirst` was deprecated in 9bdf07f. (cherry picked from commit 3aeccec)

Make pinv work for Adjoint (#29837)

bb6a9af

Fixes #29723 (cherry picked from commit a472bc7)

fix reinterpret error message string (#29844)

0861979

(cherry picked from commit 5e9feb4)

Reduce allocation in flatten (#29786)

f0badf9

(cherry picked from commit 07ea302)

Use require(pkgid, ...) instead of relative require (#29770)

facd000

Co-authored-by: Jameson Nash <[email protected]> (cherry picked from commit 6ae6551)

Fix isvalid for 3-byte overlong encoded UTF-8 sequences

8ae1d48

(cherry picked from commit 1bbea22)

KristofferC force-pushed the backport_102 branch from 03c733c to 8ae1d48 Compare November 2, 2018 20:44

ararslan removed the needs pkgeval Tests for all registered packages should be run with this change label Nov 3, 2018

ararslan merged commit b196720 into release-1.0 Nov 3, 2018

ararslan deleted the backport_102 branch November 3, 2018 19:46

DilumAluthge removed the DO NOT MERGE Do not merge this PR! label Jun 18, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

WIP: Backports for 1.0.2 #29444

WIP: Backports for 1.0.2 #29444

KristofferC commented Sep 30, 2018 •

edited

Loading

KristofferC commented Nov 2, 2018

ararslan commented Nov 3, 2018

fredrikekre commented Nov 3, 2018

KristofferC commented Nov 3, 2018

ararslan commented Nov 3, 2018

ararslan commented Nov 3, 2018

WIP: Backports for 1.0.2 #29444

WIP: Backports for 1.0.2 #29444

Conversation

KristofferC commented Sep 30, 2018 • edited Loading

KristofferC commented Nov 2, 2018

ararslan commented Nov 3, 2018

fredrikekre commented Nov 3, 2018

KristofferC commented Nov 3, 2018

ararslan commented Nov 3, 2018

ararslan commented Nov 3, 2018

KristofferC commented Sep 30, 2018 •

edited

Loading