Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add inbounds to some more substrings #29680

Merged
merged 1 commit into from
Oct 18, 2018
Merged

add inbounds to some more substrings #29680

merged 1 commit into from
Oct 18, 2018

Conversation

KristofferC
Copy link
Sponsor Member

Before

julia> @btime rstrip("dsfsdfdsf ");
  114.895 ns (4 allocations: 80 bytes)

julia> @btime lstrip(" dsfsdfdsf");
  60.079 ns (2 allocations: 48 bytes)

julia> @btime chomp("fdsfd\n");
  46.178 ns (1 allocation: 32 bytes)

julia> @btime rsplit("aba, aba, aba", ',');
  364.071 ns (6 allocations: 256 bytes)

After

julia> @btime rstrip("dsfsdfdsf ");
  101.403 ns (4 allocations: 80 bytes)

julia> @btime lstrip(" dsfsdfdsf");
  46.380 ns (2 allocations: 48 bytes)

julia> @btime chomp("fdsfd\n");
  33.989 ns (1 allocation: 32 bytes)

julia> @btime rsplit("aba, aba, aba", ',');
  328.436 ns (6 allocations: 256 bytes)

@KristofferC KristofferC added performance Must go faster strings "Strings!" labels Oct 16, 2018
@KristofferC KristofferC merged commit 5c2e0b5 into master Oct 18, 2018
@KristofferC KristofferC deleted the kc/inb_substring branch October 18, 2018 14:34
KristofferC added a commit that referenced this pull request Oct 29, 2018
KristofferC added a commit that referenced this pull request Oct 31, 2018
KristofferC added a commit that referenced this pull request Nov 2, 2018
KristofferC added a commit that referenced this pull request Feb 11, 2019
KristofferC added a commit that referenced this pull request Feb 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
performance Must go faster strings "Strings!"
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant