Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove docstring relicts of findlast/findprev with a regex #29398

Merged
merged 1 commit into from
Sep 27, 2018

Conversation

laborg
Copy link
Contributor

@laborg laborg commented Sep 27, 2018

@KristofferC
Copy link
Member

Seems like this docstring came from 93eef2d which also added

@deprecate rsearch(s::AbstractString, r::Regex, idx::Integer) findprev(r, s, idx)
@deprecate rsearch(s::AbstractString, r::Regex) findlast(r, s)

but where these rsearch methods ever defined? @nalimilan

@nalimilan
Copy link
Member

I guess I introduced these by mistake when trying to make docstrings more consistent between findfirst/findnext and findlast/findprev.

@nalimilan nalimilan merged commit 47668c8 into JuliaLang:master Sep 27, 2018
@nalimilan nalimilan added docs This change adds or pertains to documentation search & find The find* family of functions backport pending 0.7 labels Sep 27, 2018
KristofferC pushed a commit that referenced this pull request Sep 30, 2018
KristofferC pushed a commit that referenced this pull request Feb 11, 2019
KristofferC pushed a commit that referenced this pull request Feb 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs This change adds or pertains to documentation search & find The find* family of functions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants