Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve description of Julia keywords #29229

Merged
merged 2 commits into from
Sep 21, 2018

Conversation

bkamins
Copy link
Member

@bkamins bkamins commented Sep 17, 2018

Clarification of keyword arguments documentation following #29197.

@JeffBezanson JeffBezanson added the docs This change adds or pertains to documentation label Sep 18, 2018
`abstract`, `mutable`, `primitive` and `type`.

Finally `where` is resolved contextually as a keyword in parametric method
definition syntax, but creation of variable named `where` is allowed.
Copy link
Sponsor Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

where is parsed as an infix operator for writing parametric method definitions and certain types. in and isa are also parsed as infix operators. However these may generally be used as variable names.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. I have tried to improve the description.

@JeffBezanson JeffBezanson merged commit b777030 into JuliaLang:master Sep 21, 2018
@bkamins bkamins deleted the document_keywords branch September 21, 2018 11:05
KristofferC pushed a commit that referenced this pull request Sep 30, 2018
Those keywords are not allowed to be used as variable names.

The following two word sequences are reserved:
`abstract type`, `mutable struct`, `primitive type`.
Copy link
Contributor

@PallHaraldsson PallHaraldsson Oct 3, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

three word sequences, or "two-word" sequences

Copy link
Sponsor Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is better to just open a new PR with the suggested changes instead of commenting on old merged PRs.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. I will make a PR to clarify it.

KristofferC pushed a commit that referenced this pull request Feb 11, 2019
KristofferC pushed a commit that referenced this pull request Feb 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs This change adds or pertains to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants