Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix eval world updates #29765

Merged
merged 2 commits into from
Oct 25, 2018
Merged

fix eval world updates #29765

merged 2 commits into from
Oct 25, 2018

Conversation

vtjnash
Copy link
Member

@vtjnash vtjnash commented Oct 22, 2018

Fix a missing (couple of) world update, and clean up the code to ensure the world update is close to the use site, and not dependent on some nested old update.

@vtjnash
fix compiler warnings
a928ec5 
incorrect code introduced by 68cc9f0
@vtjnash
fix eval world updates
715e0eb 
These were scattered about conservatively, and not always in the right places.
Here we narrow them to apply more specifically, and remove several that should not be observable.

fix #29761
@vtjnash vtjnash added bugfix This change fixes an existing bug backport pending 1.0 labels Oct 22, 2018
@vtjnash vtjnash merged commit 36e21d4 into master Oct 25, 2018
@vtjnash vtjnash deleted the jn/29761 branch October 25, 2018 04:50
@KristofferC KristofferC mentioned this pull request Oct 29, 2018
Merged
@KristofferC
Copy link
Member

Doesn't backport cleanly.

vtjnash added a commit that referenced this pull request Oct 29, 2018
@vtjnash
fix eval world updates
181df8b 
These were scattered about conservatively, and not always in the right places.
Here we narrow them to apply more specifically, and remove several that should not be observable.

fix #29761

(cherry picked from commit 715e0eb, PR #29765)
KristofferC pushed a commit that referenced this pull request Oct 31, 2018
@vtjnash @KristofferC
fix eval world updates
03c0a18 
These were scattered about conservatively, and not always in the right places.
Here we narrow them to apply more specifically, and remove several that should not be observable.

fix #29761

(cherry picked from commit 715e0eb, PR #29765)
KristofferC pushed a commit that referenced this pull request Nov 2, 2018
@vtjnash @KristofferC
fix eval world updates
87d94ea 
These were scattered about conservatively, and not always in the right places.
Here we narrow them to apply more specifically, and remove several that should not be observable.

fix #29761

(cherry picked from commit 715e0eb, PR #29765)
KristofferC pushed a commit that referenced this pull request Feb 11, 2019
@vtjnash @KristofferC
fix eval world updates
1170375 
These were scattered about conservatively, and not always in the right places.
Here we narrow them to apply more specifically, and remove several that should not be observable.

fix #29761

(cherry picked from commit 715e0eb, PR #29765)
KristofferC pushed a commit that referenced this pull request Feb 20, 2020
@vtjnash @KristofferC
fix eval world updates
8a6fd98 
These were scattered about conservatively, and not always in the right places.
Here we narrow them to apply more specifically, and remove several that should not be observable.

fix #29761

(cherry picked from commit 715e0eb, PR #29765)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bugfix This change fixes an existing bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vtjnash @KristofferC