Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #29454: better example for mutable struct #29475

Merged
merged 1 commit into from
Oct 2, 2018
Merged

fix #29454: better example for mutable struct #29475

merged 1 commit into from
Oct 2, 2018

Conversation

don-suth
Copy link
Contributor

@don-suth don-suth commented Oct 2, 2018

Changed String to BitSet as a mutable struct example.

@don-suth
Closed issue JuliaLang#29454
9700ede 
Changed `String` to `BitSet` as a `mutable struct` example.
@fredrikekre fredrikekre changed the title Closed issue #29454 fix #29454: better example for mutable struct Oct 2, 2018
@fredrikekre fredrikekre added docs This change adds or pertains to documentation backport pending 1.0 labels Oct 2, 2018
@fredrikekre
Copy link
Member

fredrikekre commented Oct 2, 2018 •
edited
Loading

Welcome as a contributor to Julia!

cc @oxinabox

@StefanKarpinski StefanKarpinski merged commit dee7d77 into JuliaLang:master Oct 2, 2018
@StefanKarpinski
Copy link
Sponsor Member

Thanks for the contribution, BitSet is definitely a better example than String (which is neither a struct nor mutable!).

@KristofferC KristofferC mentioned this pull request Oct 2, 2018
Closed
KristofferC pushed a commit that referenced this pull request Oct 6, 2018
@don-suth @KristofferC
Closed issue #29454 (#29475)
f362fb5 
Changed `String` to `BitSet` as a `mutable struct` example.

(cherry picked from commit dee7d77)
@KristofferC KristofferC mentioned this pull request Oct 6, 2018
Merged
KristofferC pushed a commit that referenced this pull request Feb 11, 2019
@don-suth @KristofferC
Closed issue #29454 (#29475)
611e40f 
Changed `String` to `BitSet` as a `mutable struct` example.

(cherry picked from commit dee7d77)
KristofferC pushed a commit that referenced this pull request Feb 20, 2020
@don-suth @KristofferC
Closed issue #29454 (#29475)
8baea1c 
Changed `String` to `BitSet` as a `mutable struct` example.

(cherry picked from commit dee7d77)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
docs This change adds or pertains to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@don-suth @fredrikekre @StefanKarpinski @KristofferC