Created an actual table [Manual,Scope of Variables] #29789
Conversation
It looks clearer to me, by showing immediately the *constructs* the document talks about. In the the original tree , a complete beginner may confuse which are the constructs, and which are the types of scope Also removed the mention "(don't allow nesting)" in the 5th branch of the tree, as that is already stated by the 1st branch of the tree (It had actually confused me https://discourse.julialang.org/t/scope-of-struct-and-macro/16714 )
ghost
changed the title
ghost
changed the title
|
I've no idea what those "checks" failed below mean, I'm just editing the documentation, by following the "Edit on Github" link from https://docs.julialang.org/en/v1/manual/variables-and-scoping/#man-scope-table-1 |
|
Welcome and thanks for the contribution! If you click the "Details" link next to each of the continuous integration checks, you can see a log for the job that ran the tests. In this case, they're failing because your changed introduced trailing whitespace. You can fix that by deleting the spaces at the end of the line on lines 24 and 25 of the file. |
|
Thanks @ararslan ! |
|
It needs to build Julia in order to build the docs. |
|
Wow, that sounds overkill (and waste of github resources), from my newbie perspective. I think there should be leaner ways to check doc changes only |
The doctests need to be run and to do that you need to have Julia built to run it. |
|
If the changes only affect documentation, cannot you use an already built version of Julia to run the doctests? |
|
No :). It would be more productive to focus on the content of the PR instead of how CI is done. |
| (mutable) [`struct`](@ref), [`macro`](@ref) | local | other global | ||
| [`for`](@ref), [`while`](@ref), [`try-catch-finally`](@ref try), [`let`](@ref) |local | other local | ||
| functions (either syntax, anonymous & do-blocks) | local | other local | ||
| comprehensions, broadcast-fusing | local | other local |
There was a problem hiding this comment.
The three last rows here should state other local or global as per the old docs I assume?
There was a problem hiding this comment.
Ah, how could I miss that :( !!
(but I knew those 3 constructs can nest in either global or local scopes).
Thanks for checking
fredrikekre
added
docs
|
👏 |
ghost
deleted the
(cherry picked from commit 679c5b5)
(cherry picked from commit 679c5b5)
(cherry picked from commit 679c5b5)
(cherry picked from commit 679c5b5)
It looks clearer to me, by showing immediately the constructs the document talks about.
In the the original tree , a complete beginner may confuse which are the constructs, and which are the types of scope
Also removed the mention "(don't allow nesting)" in the 5th branch of the tree, as that is already stated by the 1st branch of the tree
(It had actually confused me https://discourse.julialang.org/t/scope-of-struct-and-macro/16714 )