adding _small_enough for diagonal so that fill! works #29780
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fredrikekre
added
linear algebra
fredrikekre
approved these changes
Oct 23, 2018
stdlib/LinearAlgebra/test/bidiag.jl
Outdated
| @@ -346,7 +346,7 @@ using LinearAlgebra: fillstored!, UnitLowerTriangular | |||
| sparse(rand(3)), | |||
| # LowerTriangular(randn(3,3)), # AbstractTriangular fill! deprecated, see below | |||
| # UpperTriangular(randn(3,3)) # AbstractTriangular fill! deprecated, see below | |||
| ] | |||
| Diagonal(rand(3))] | |||
There was a problem hiding this comment.
Maybe just uncomment L345 instead?
fredrikekre
approved these changes
Oct 24, 2018
KristofferC
pushed a commit
that referenced
this pull request
Oct 29, 2018
(cherry picked from commit ee08fd6)
KristofferC
pushed a commit
that referenced
this pull request
Feb 11, 2019
(cherry picked from commit ee08fd6)
KristofferC
pushed a commit
that referenced
this pull request
Feb 20, 2020
(cherry picked from commit ee08fd6)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_small_enoughwasn't defined forDiagonalsofill!(::Diagonal, x)returns a method error even if the diagonal matrix is small enough.2 small questions: should the fill and fillstored tests be in test/special.jl (instead of bidiag.jl) since that is where they are defined? And should fillstored be exported by LinearAlgebra?