Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #29644: getproperty of Tridiagonal{SparseVector} #29646

Merged
merged 2 commits into from
Oct 16, 2018
Merged

fix #29644: getproperty of Tridiagonal{SparseVector} #29646

merged 2 commits into from
Oct 16, 2018

Conversation

fredrikekre
Copy link
Member

No description provided.

@fredrikekre fredrikekre added linear algebra Linear algebra bugfix This change fixes an existing bug backport pending 1.0 labels Oct 15, 2018
@fredrikekre fredrikekre changed the title fix #29644: getfield of Tridiagonal{SparseVector} fix #29644: getproperety of Tridiagonal{SparseVector} Oct 15, 2018
@fredrikekre fredrikekre changed the title fix #29644: getproperety of Tridiagonal{SparseVector} fix #29644: getproperty of Tridiagonal{SparseVector} Oct 15, 2018
andreasnoack
andreasnoack approved these changes Oct 15, 2018
View reviewed changes
Copy link
Member

@andreasnoack andreasnoack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should fix the immediate problem here but eventually, we should probably try to come up with a more efficient representation of L. The current one could easily cause the machine to run out of memory.

@fredrikekre
Copy link
Member Author

try to come up with a more efficient representation of L

We could just skip the Array call for both L and U and return Bidiagonal?

@andreasnoack
Copy link
Member

We could just skip the Array call for both L and U and return Bidiagonal?

That won't work. Notice the loop right below your change. It applies the permutation which breaks the bidiagonal patterns of L. Hence a banded type would work but we don't have that in LinearAlgebra. An alternative would be some kind of composition of Bidiagonal and a permutation matrix.

@andreasnoack andreasnoack merged commit 0902d58 into master Oct 16, 2018
@andreasnoack andreasnoack deleted the fe/tridiag branch October 16, 2018 07:42
@KristofferC KristofferC mentioned this pull request Oct 19, 2018
Merged
KristofferC pushed a commit that referenced this pull request Oct 19, 2018
@fredrikekre @KristofferC
fix #29644: getproperty of Tridiagonal{SparseVector} (#29646)
4a96798 
* fix #29644: getfield of Tridiagonal{SparseVector}

* Fix tests.

(cherry picked from commit 0902d58)
KristofferC pushed a commit that referenced this pull request Feb 11, 2019
@fredrikekre @KristofferC
fix #29644: getproperty of Tridiagonal{SparseVector} (#29646)
0ce2865 
* fix #29644: getfield of Tridiagonal{SparseVector}

* Fix tests.

(cherry picked from commit 0902d58)
KristofferC pushed a commit that referenced this pull request Feb 20, 2020
@fredrikekre @KristofferC
fix #29644: getproperty of Tridiagonal{SparseVector} (#29646)
44bf22b 
* fix #29644: getfield of Tridiagonal{SparseVector}

* Fix tests.

(cherry picked from commit 0902d58)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreasnoack andreasnoack andreasnoack approved these changes

Assignees
No one assigned
Labels
bugfix This change fixes an existing bug linear algebra Linear algebra
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fredrikekre @andreasnoack @KristofferC