Fix: Complex SubArray times real Matrix #29246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @testset "Combination $T1 $T2 $arg1_real $arg2_real" for arg2_real in (true,false) | ||
| A0 = reshape(Vector{T1}(1:25),5,5) .+ | ||
| (arg1_real ? 0 : 1im*reshape(Vector{T1}(-3:21),5,5)) | ||
| A = view(A0,1:2,1:2) |
There was a problem hiding this comment.
Maybe also add a test with view(A0,:,1:2) to test the code path that dispatches to BLAS.
andreasnoack
approved these changes
Sep 18, 2018
|
Sure. For the record: This leads to another situation the trick is used and it also does not work: |
|
Done. All three reinterpret tricks are now changed. |
KristofferC
added
linear algebra
KristofferC
pushed a commit
that referenced
this pull request
Sep 30, 2018
* gemm_wrapper! -> mul! (#29224) * testing for #29224 * code review update: More tests * Complex times real reinterpret trick fix for vectors and transposed matrices (cherry picked from commit 82503cd)
KristofferC
pushed a commit
that referenced
this pull request
Feb 11, 2019
* gemm_wrapper! -> mul! (#29224) * testing for #29224 * code review update: More tests * Complex times real reinterpret trick fix for vectors and transposed matrices (cherry picked from commit 82503cd)
KristofferC
pushed a commit
that referenced
this pull request
Feb 20, 2020
* gemm_wrapper! -> mul! (#29224) * testing for #29224 * code review update: More tests * Complex times real reinterpret trick fix for vectors and transposed matrices (cherry picked from commit 82503cd)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes JuliaLang/LinearAlgebra.jl#566 concerning multiplication of a complex SubArray with a real matrix. The only substantial change is
to
This allows dispatch to determine if we can use
gemmfor the reinterpreted matrix, or just do it through the fallbackgeneric_matmatmul!.