Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overloading getproperty in REPL doesn't work (master) #29761

Closed
KristofferC opened this issue Oct 22, 2018 · 3 comments
Closed

Overloading getproperty in REPL doesn't work (master) #29761

KristofferC opened this issue Oct 22, 2018 · 3 comments
Assignees
Labels
bug Indicates an unexpected problem or unintended behavior

Comments

@KristofferC
Copy link
Sponsor Member

KristofferC commented Oct 22, 2018

Executing

struct S
    x
end

function Base.getproperty(x::S, sym::Symbol)
    println("called")
    return getfield(x, sym)
end

S(1).x

on julia 1.0.1

gives

julia> S(1).x
called
1

while on master

julia> S(1).x
1

julia> @which S(1).x
getproperty(x::S, sym::Symbol) in Main at REPL[2]:2

So the overload doesn't seem to take.

@StefanKarpinski
Copy link
Sponsor Member

cc @Keno, @vtjnash

@KristofferC KristofferC added the bug Indicates an unexpected problem or unintended behavior label Oct 22, 2018
@JeffBezanson
Copy link
Sponsor Member

I think ea7b1a7 dropped a world age update.

@vtjnash vtjnash self-assigned this Oct 22, 2018
vtjnash added a commit that referenced this issue Oct 22, 2018
These were scattered about conservatively, and not always in the right places.
Here we narrow them to apply more specifically, and remove several that should not be observable.

fix #29761
@vtjnash
Copy link
Sponsor Member

vtjnash commented Oct 22, 2018

Actually it was 2ba69e8 that dropped the world update.

vtjnash added a commit that referenced this issue Oct 29, 2018
These were scattered about conservatively, and not always in the right places.
Here we narrow them to apply more specifically, and remove several that should not be observable.

fix #29761

(cherry picked from commit 715e0eb, PR #29765)
KristofferC pushed a commit that referenced this issue Oct 31, 2018
These were scattered about conservatively, and not always in the right places.
Here we narrow them to apply more specifically, and remove several that should not be observable.

fix #29761

(cherry picked from commit 715e0eb, PR #29765)
KristofferC pushed a commit that referenced this issue Nov 2, 2018
These were scattered about conservatively, and not always in the right places.
Here we narrow them to apply more specifically, and remove several that should not be observable.

fix #29761

(cherry picked from commit 715e0eb, PR #29765)
KristofferC pushed a commit that referenced this issue Feb 11, 2019
These were scattered about conservatively, and not always in the right places.
Here we narrow them to apply more specifically, and remove several that should not be observable.

fix #29761

(cherry picked from commit 715e0eb, PR #29765)
KristofferC pushed a commit that referenced this issue Feb 20, 2020
These were scattered about conservatively, and not always in the right places.
Here we narrow them to apply more specifically, and remove several that should not be observable.

fix #29761

(cherry picked from commit 715e0eb, PR #29765)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Indicates an unexpected problem or unintended behavior
Projects
None yet
Development

No branches or pull requests

4 participants