English fixes #29336
Merged
English fixes #29336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I did not change "i.e." to "i.e.," even though I think the latter is better since the former seems to be your standard. I find the package name 'Priv' v. confusing esp. in contexts like "The public `Priv`" etc. I think Util would be a more plausible and less confusing example name. (I also think 'Pub' ought to be replaced by a more plausible name, e.g., 'Process' or 'Compute'.) I find it confusing that the text mentions the "/home/me/animals" directory, but then shows a dictionary using "/home/me/AnimalPackages". PS I tried doing this from a local git clone but when I did the git push it gave me a 403. I did git clone ...julia.git, the cd'd into julia, then did git checkout -b english_fixes, then made my changes and did git commit -a, put in the comments above, then did git push --set-upstream origin english_fixes, entered my git username and password -- and then got the 403. I can carry on using the web interface though.
StefanKarpinski
approved these changes
Sep 24, 2018
You probably need to add your fork as a remote, since you can not push to the |
KristofferC
pushed a commit
that referenced
this pull request
Oct 6, 2018
(cherry picked from commit 7dd1e4c)
KristofferC
pushed a commit
that referenced
this pull request
Feb 11, 2019
(cherry picked from commit 7dd1e4c)
KristofferC
pushed a commit
that referenced
this pull request
Feb 20, 2020
(cherry picked from commit 7dd1e4c)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I did not change "i.e." to "i.e.," even though I think the latter is better since the former seems to be your standard.
I find the package name 'Priv' v. confusing esp. in contexts like "The public
Priv" etc. I think Util would be a more plausible and lessconfusing example name. (I also think 'Pub' ought to be replaced by a more plausible name, e.g., 'Process' or 'Compute'.)
I find it confusing that the text mentions the "/home/me/animals" directory, but then shows a dictionary using "/home/me/AnimalPackages".
PS I tried doing this from a local git clone but when I did the git push it gave me a 403.
I did git clone ...julia.git, the cd'd into julia, then did git checkout -b english_fixes, then made my changes and did git commit -a, put in the comments above, then did git push --set-upstream origin english_fixes, entered my git username and password -- and then got the 403. I can carry on using the web interface though, but then you'll end up with lots of small commits -- but maybe you prefer than anyway.