Reinstate statically computed log event ids #29878
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There was a couple of win32 CI profile test failures which looked bizarre and unrelated so I restarted that. Here's a separate issue for that: #29880 |
Closed
|
Putting a priority label on this since we want this in 1.0.2 which we want to run PkgEval and release as soon as possible. |
|
LGTM. |
KristofferC
pushed a commit
that referenced
this pull request
Nov 1, 2018
* fix bug and add tests * Reinstate statically computed log record ids Log ids are meant to identify the location of the message in the source code and must be computed at compile time. fix #28786, fix #28400; closes #29355. * Clarify documentation regarding log record `id` (cherry picked from commit 51683c4)
|
Thanks guys, getting this into 1.0.2 will be great. @adamslc looks like your patch got mashed together with mine in the merge. Sorry about that :-/ |
|
No worries. Just glad to have this bug fixed. |
KristofferC
pushed a commit
that referenced
this pull request
Nov 2, 2018
* fix bug and add tests * Reinstate statically computed log record ids Log ids are meant to identify the location of the message in the source code and must be computed at compile time. fix #28786, fix #28400; closes #29355. * Clarify documentation regarding log record `id` (cherry picked from commit 51683c4)
odow
added a commit
to jump-dev/JuMP.jl
that referenced
this pull request
Dec 30, 2018
This was fixed by JuliaLang/julia#29878
odow
added a commit
to jump-dev/JuMP.jl
that referenced
this pull request
Dec 30, 2018
* Remove outdated comment We retain `copy_names = true` for explicitness. * Remove outdated comment. This was fixed by JuliaLang/julia#29878
KristofferC
pushed a commit
that referenced
this pull request
Feb 11, 2019
* fix bug and add tests * Reinstate statically computed log record ids Log ids are meant to identify the location of the message in the source code and must be computed at compile time. fix #28786, fix #28400; closes #29355. * Clarify documentation regarding log record `id` (cherry picked from commit 51683c4)
KristofferC
pushed a commit
that referenced
this pull request
Feb 20, 2020
* fix bug and add tests * Reinstate statically computed log record ids Log ids are meant to identify the location of the message in the source code and must be computed at compile time. fix #28786, fix #28400; closes #29355. * Clarify documentation regarding log record `id` (cherry picked from commit 51683c4)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Log
ids are meant to identify the location of the message in the source code and must be computed at compile time.For further commentary on this proposed fix see #29355 (comment) and #29355 (comment)
Fixes #28786, fixes #28400 and closes #29355.
@adamslc I incorporated your tests in here (lightly modified)
@oxinabox @iamed2 @samoconnor you'll need this to fix #28400 before using the new logging infrastructure in any serious way for long running tasks. [Yikes, what a horrible bug :-( ]