-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
maxintfloat should return an ::Integer #29297
Comments
The word "integer" is a bit ambiguous in this case it means "integer-valued floating point number", so we could replace the word with that in the docs. Changing the type returned would be a breaking change, so we're not going to do that but you can easily just do |
Not quite, eg I will make a PR about the documentation then, and perhaps mention this? |
Yes, that would be great! |
Fixes JuliaLang#29297, see discussion there.
I think it makes sense to return special values of a type as that type itself. Improving the docs sounds like the right thing here. |
Fixes #29297, see discussion there.
Contrary to its documentation which says (emphasis mine)
it actually returns floating point values.
I don't know if this is a problem with wording or the implementation. IMO returning integers would be more useful as one could perform exact arithmetic & comparisons with them around the edge of the representable region.
The text was updated successfully, but these errors were encountered: