Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

egal_tfunc bugfix #29838

Merged
merged 3 commits into from
Oct 31, 2018
Merged

egal_tfunc bugfix #29838

merged 3 commits into from
Oct 31, 2018

Conversation

vtjnash
Copy link
Sponsor Member

@vtjnash vtjnash commented Oct 29, 2018

fix #29836

(reviewer note: this is two NFC commits to make the code a bit more consistent + the fix itself)

@vtjnash
inference: fix efficiency of tfunc key lookup
3aeccec 
This was broken when `findfirst` was deprecated in 9bdf07f.
@vtjnash
inference: give all tfuncs names
440a145 
To make accessing them for testing less awkward.
@vtjnash
inference: fix egal_tfunc for Conditional
e270fbb 
Oops.

fixes #29836, and adds explicit test coverage
@thautwarm
Copy link
Member

nice!

@thautwarm
Copy link
Member

Hi, when will this be released? I mean the release with this bugfix.
Have to be a bit curious, for tesing my package depends on it.

@KristofferC KristofferC mentioned this pull request Oct 29, 2018
Merged
@KristofferC
Copy link
Sponsor Member

Good to go?

@Keno Keno merged commit 3a43157 into master Oct 31, 2018
@martinholters martinholters deleted the jn/29836 branch October 31, 2018 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Keno Keno Keno approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

true === nothing when expanding macro.
4 participants
@vtjnash @thautwarm @KristofferC @Keno