Deploy RC 186 to Production#6189
Merged
zachmargolis merged 22 commits intostages/prodfrom Apr 14, 2022
Merged
Conversation
[skip changelog]
* log SAML auth requests as well * Account for authpost * check for nil * fix specs * add SAML Auth request spec changelog: Internal, Logging, Log external SAML authentication requests * add POST spec * rename analytics attributes to be clearer * simplify analytics call Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com> * move POST spec to feature spec * fix SAML post url Co-authored-by: Oren Kanner <oren.kanner@gsa.gov> Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>
* download personal key via data: URL or JS fallback for Internet Explorer * add specs and removal notes changelog: Bug Fixes, Personal keys, Fixes downloading personal keys outside of identity verification
* Replace custom color variables with design system tokens **Why**: So that we have a single source of truth for colors, to improve consistency and reduce confusion. changelog: Improvements, Layout, Use design system tooling for page layouts * Remove color list variations **Why**: For consistency with design system * Use StatusPageComponent for IDV forgot password * Refactor IDV forgot password warning strings to array
* Reimplement password toggle as reusable component **Why**: - Consolidate common implementation between password and SSN toggle - Reduce size and scope of application JavaScript pack - Reduce attack surface area by avoiding injected interpolated string data (insertAdjacentHTML) - Fix tab order mismatched with visual placement (WCAG 2.1 G59) - Improve accessibility by establishing relationship between toggle and input, and announcing state changes via live region changelog: Improvements, Accessibility, Fix tab order and add relational linking for password visibility toggle * Add support for once with class function * Replace all password-toggle inputs with PasswordToggleComponent * Fix pw-strength ID-based password-field querying * Remove unused required attr_reader * Add PasswordToggleComponent specs * Add PasswordToggleElement specs * Make toggle class modifiers searchable See: https://github.com/18F/identity-idp/pull/6081/files#r831495340 * Remove visible state announcements * Add default component label translations * Consolidate "Show password" label locale data * Fix lint formatting issues Hello Prettier 2.6 * Improve specs (avoid internal element references) * Avoid conflicting validators for IDV password field * Retain incoming aria-describedby for ValidatedField **Why**: Because rendering view may have its own descriptor, in addition to the field's own error description. aria-describedby is an "ID reference list", meaning it can support multiple, space-separated IDs. Ref: https://www.w3.org/TR/wai-aria-1.1/#aria-describedby
**Why**: Unused as of #6161 changelog: Internal, Source code, Remove unused download code
* add failing spec * Remove identity_needs_verification and profile_needs_verification from SAML logging changelog: Bug Fix, Logging, Fix bug in logging external SAML authentication requests
**Why**: - Because they're unused, originally implemented for an early prototype of document capture (#3942) - So that the remaining "full screen" styles used by document capture are only loaded as part of the document capture stylesheet, to reduce the size and scope of the common application stylesheet changelog: Internal, Optimize, Remove unused stylesheet styles
- It's stale and unused [skip changelog]
* Migrate EVENT_DISAVOWAL_TOKEN_INVALID event * Migrate EVENTS_VISIT event * Migrate EXTERNAL_REDIRECT event * Migrate FORGET_ALL_BROWSERS_SUBMITTED Migrate * FORGET_ALL_BROWSERS_VISITED changelog: Internal, Documentation, Document additional analytics events
* return to sp failure to proof * rules of use visit * Rules of Use Submitted * security event received * service provider revoke consent revoked * service provider revoke consent visited changelog: Internal, Documentation, Document additional analytics events Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>
**Why**: - Per discovery in LG-5420, it's not necessary. - Its behavior is especially conflicting with React-based submission handling, as it globally handles the submit event, so this helps with ongoing FlowStateMachine work. - Reduce size and scope of common application bundle changelog: Internal, Optimization, Remove unnecessary JavaScript
**Why:** Preparatory work ahead of upcoming FlowStateMachine v2 work, where it's expected a new form-steps package would need to share usage of these hooks with the existing document-capture package. [skip changelog]
* Add sp-costs-v2 report * Update with feedback - Group by cost (not by SP) - Remove IAL 1 costs - Rename to match new usage (total IAL2 costs) changelog: Internal, Reporting, Add total IAL2 costs report for last 45 days
**Why**: Preparatory work ahead of upcoming FlowStateMachine v2 work, where it's expected we will want to lift out this component to a shared package to reuse for other steps in the flow. [skip changelog]
* Move button to components package **Why**: Preparatory work ahead of upcoming FlowStateMachine v2 work, where it's expected we will want to use this component in packages outside document-capture. [skip changelog] * Convert Button to TypeScript
* Refactor FormSteps message handling to work with generic error **Why**: Since we plan to use FormSteps outside the context of document capture for FlowStateMachine v2, it shouldn't be so strongly aware of specific error types (via FormErrorMessage). The previous implementation was also largely motivated by the inability to translate strings outside the context of a React context, which is no longer the case. [skip changelog] * Extract nonBreaking function for string manipulation See: https://github.com/18F/identity-idp/pull/6176/files#r845348796
* changelog: Bug, Prevent ios from prompting for credit card on otp input, LG-6047 * comments to warn folks in yaml files
* Stop updating existing sp_return_logs rows changelog: Internal, Optimization, Remove functionality that supported backwards compatibility for billing functionality during deploy * clean up comment
Contributor
Contributor
Author
* Bump nokogiri from 1.13.3 to 1.13.4 Bumps [nokogiri](https://github.com/sparklemotion/nokogiri) from 1.13.3 to 1.13.4. - [Release notes](https://github.com/sparklemotion/nokogiri/releases) - [Changelog](https://github.com/sparklemotion/nokogiri/blob/v1.13.4/CHANGELOG.md) - [Commits](sparklemotion/nokogiri@v1.13.3...v1.13.4) --- updated-dependencies: - dependency-name: nokogiri dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com> * Add changelog changelog: Internal, Dependencies, Update dependencies to address security advisories Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov> (cherry picked from commit 8b8ec06)
**Why**: Since it may have a negative impact on form usability, revert until we have a chance to think about this more holistically. [skip changelog] (cherry picked from commit 22c3d73)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(plus some alpbabetizing)
Improvements
Fix tab order and add relational linking for password visibility toggle(#6081)Bug Fixes
Internal