Skip to content

Replace custom color variables with design system tokens#6086

Merged
aduth merged 4 commits intomainfrom
aduth-ds-colors
Apr 6, 2022
Merged

Replace custom color variables with design system tokens#6086
aduth merged 4 commits intomainfrom
aduth-ds-colors

Conversation

@aduth
Copy link
Contributor

@aduth aduth commented Mar 17, 2022

Why: So that we have a single source of truth for colors, to improve consistency and reduce confusion.

Largely, there should not be any meaningful differences from this change. However, to the above point about consistency, there are a few minor differences between our ad hoc colors and the design system:

Before After Usage
#e1ce28 ($yellow) #f5d600 (warning)
  • IAL2 cancellation warning list Edit: Removed
#00bfe7 ($teal) #00a2c4 (info)
  • Session timeout modal
  • IAL2 forgot password warning list Edit: Removed
#5b616a ($gray) #454545 (ink)
  • Form field text color

Reference: https://design.login.gov/utilities/color/

This retains existing styling for email templates, but those should ideally be updated to use design system tokens as well.

Copy link
Contributor

@nickttng nickttng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Slightly off-topic: About the warning lists here, have there been any discussions about aligning these bullet points with the LGDS?

@aduth
Copy link
Contributor Author

aduth commented Mar 18, 2022

Slightly off-topic: About the warning lists here, have there been any discussions about aligning these bullet points with the LGDS?

Yeah, I think we've been generally moving away from them. I'd be happy to do it sooner than later, maybe even as part of this pull request.

For context, it would be these two lists:

Screen Shot 2022-03-18 at 8 30 41 AM

Screen Shot 2022-03-18 at 8 31 21 AM

Copy link
Contributor

@anniehirshman-gsa anniehirshman-gsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and I'm all for standardizing the bullet styles on those two pages as well!

@aduth
Copy link
Contributor Author

aduth commented Mar 18, 2022

👍 I removed all the color list variations in df2bd9d.

Screen Before After
IAL2 Cancel Confirm localhost_3000_verify_cancel_step=welcome localhost_3000_verify_cancel_step=welcome (1)
IAL2 Cancelled localhost_3000_verify_cancel_location=cancel step=review localhost_3000_verify_cancel_location=cancel step=review (1)
IAL2 Forgot Password localhost_3000_verify_forgot_password localhost_3000_verify_forgot_password (1)

@anniehirshman-gsa
Copy link
Contributor

LGTM! Thanks for confirming with the screenshots.

@aduth aduth force-pushed the aduth-ds-colors branch from 47d2019 to 38b76e2 Compare April 1, 2022 13:20
@aduth
Copy link
Contributor Author

aduth commented Apr 1, 2022

Spotted another, with IAL1 account creation cancellation, updated in 38b76e2:

Before After
Screen Shot 2022-04-01 at 9 18 37 AM Screen Shot 2022-04-01 at 9 19 48 AM

@anniehirshman-gsa
Copy link
Contributor

Spotted another, with IAL1 account creation cancellation

LGTM also!

**Why**: So that we have a single source of truth for colors, to improve consistency and reduce confusion.

changelog: Improvements, Layout, Use design system tooling for page layouts
@aduth aduth force-pushed the aduth-ds-colors branch from 077ccd8 to b18dcf2 Compare April 4, 2022 12:47
**Why**: For consistency with design system
@aduth aduth force-pushed the aduth-ds-colors branch from b18dcf2 to b971299 Compare April 4, 2022 12:48
@aduth aduth merged commit f5c7db3 into main Apr 6, 2022
@aduth aduth deleted the aduth-ds-colors branch April 6, 2022 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants