Skip to content

Fix SAML Auth 500 at IAL2#6166

Merged
mitchellhenke merged 2 commits intomainfrom
mitchellhenke/fix-saml-500-at-ial2
Apr 6, 2022
Merged

Fix SAML Auth 500 at IAL2#6166
mitchellhenke merged 2 commits intomainfrom
mitchellhenke/fix-saml-500-at-ial2

Conversation

@mitchellhenke
Copy link
Contributor

@mitchellhenke mitchellhenke commented Apr 6, 2022

#6155 has a bug where SAML requests at IAL2 will 500 (NR Link)

wrote a failing test, and fixed in the commit after

  1) saml api when sending POST request to /api/saml/auth/ logs one SAML Auth Requested event and multiple SAML Auth events for IAL2 request
     Failure/Error: ial2_requested? && current_user.decorate.identity_not_verified?

     NoMethodError:
       undefined method `decorate' for nil:NilClass
     # ./app/controllers/concerns/saml_idp_auth_concern.rb:116:in `identity_needs_verification?'

@mitchellhenke mitchellhenke force-pushed the mitchellhenke/fix-saml-500-at-ial2 branch from c724836 to a49f2c5 Compare April 6, 2022 18:24
zachmargolis
zachmargolis approved these changes Apr 6, 2022
View reviewed changes
Copy link
Contributor

@zachmargolis zachmargolis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mitchellhenke mitchellhenke force-pushed the mitchellhenke/fix-saml-500-at-ial2 branch 2 times, most recently from 06ab64c to 553c963 Compare April 6, 2022 18:45
@mitchellhenke mitchellhenke force-pushed the mitchellhenke/fix-saml-500-at-ial2 branch 2 times, most recently from 6de489c to cca8d69 Compare April 6, 2022 19:01
Remove identity_needs_verification and profile_needs_verification fro…
30b3327 
…m SAML logging

changelog: Bug Fix, Logging, Fix bug in logging external SAML authentication requests
@mitchellhenke mitchellhenke force-pushed the mitchellhenke/fix-saml-500-at-ial2 branch from cca8d69 to 30b3327 Compare April 6, 2022 19:09
@mitchellhenke mitchellhenke merged commit ebc2636 into main Apr 6, 2022
@mitchellhenke mitchellhenke deleted the mitchellhenke/fix-saml-500-at-ial2 branch April 6, 2022 19:19
mitchellhenke pushed a commit that referenced this pull request Apr 6, 2022
Fix SAML Auth 500 at IAL2 (#6166)
1ae60c7 
* add failing spec

* Remove identity_needs_verification and profile_needs_verification from SAML logging

changelog: Bug Fix, Logging, Fix bug in logging external SAML authentication requests
@zachmargolis zachmargolis mentioned this pull request Apr 12, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@orenyk orenyk Awaiting requested review from orenyk

2 more reviewers

@zachmargolis zachmargolis zachmargolis approved these changes

@jmhooper jmhooper jmhooper approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mitchellhenke @zachmargolis @jmhooper