LG-5911: Fix detailed camera access error alert display#6131
Merged
Conversation
**Why**: So that the user is shown a detailed alert message describing steps to take to resolve permissions issues preventing us from being able to capture a photo. changelog: Bug Fixes, Document Capture, Show detailed alert message describing steps to resolve declined camera permission
not rendered in context of formsteps anyways to verify non-rendering of alert
mitchellhenke
approved these changes
Apr 1, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why: So that the user is shown a detailed alert message describing steps to take to resolve permissions issues preventing us from being able to capture a photo.
This appears to have been a regression of #5593. As part of those changes, the "unknown field errors" we receive from the server were adapted to be shown as plain text, in place of the alert banner that had existed previously. However, this should have only applied for the "unknown field errors" received from the server, not also to the step errors which we use for behaviors like responding to camera access declined. The changes here effectively restore this behavior for rendering step errors as alert banners, while maintaining the intended effect of #5593 to show unknown field errors as plain text.
Screenshot: