Skip to content

changelog: Improvements, remove redundant styling with style-guide, L…#6120

Merged
SammySteiner merged 1 commit intomainfrom
LG-5883-mfa-icon-styles
Mar 31, 2022
Merged

changelog: Improvements, remove redundant styling with style-guide, L…#6120
SammySteiner merged 1 commit intomainfrom
LG-5883-mfa-icon-styles

Conversation

@SammySteiner
Copy link
Contributor

…G-5883

Why

Styles were added directly to the idp in the past for mfa-icons for expediency, but we're now ready to migrate them into the style-guide. Therefore, we're removing them from the idp as they will become redundant.

Relevant style-guide pull request: 18F/identity-design-system#309

@SammySteiner SammySteiner merged commit 6dbaa3d into main Mar 31, 2022
@SammySteiner SammySteiner deleted the LG-5883-mfa-icon-styles branch March 31, 2022 13:17
@aduth
Copy link
Contributor

aduth commented Mar 31, 2022

We'll still need to update to a version of the identity-style-guide package that includes the changes from 18F/identity-design-system#309. Currently, these styles won't be applied.

@SammySteiner
Copy link
Contributor Author

We'll still need to update to a version of the identity-style-guide package that includes the changes from 18F/identity-style-guide#309. Currently, these styles won't be applied.

Did I miss a step here or in the style-guide?

@aduth
Copy link
Contributor

aduth commented Mar 31, 2022

We'll still need to update to a version of the identity-style-guide package that includes the changes from 18F/identity-style-guide#309. Currently, these styles won't be applied.

Did I miss a step here or in the style-guide?

Both:

  • We need to publish a new version of the identity-style-guide package
  • We need to update this project to use that new version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants