Do not 500 when verifying webauthn key#6144
Merged
mitchellhenke merged 1 commit intomainfrom Apr 4, 2022
Merged
Conversation
aduth
approved these changes
Apr 4, 2022
Contributor
aduth
left a comment
aduth
left a comment
There was a problem hiding this comment.
Would it be possible to create a spec for this?
changelog: Bug Fixes, Authentication, Fix error when unable to validate WebAuthn signature
mitchellhenke
force-pushed
the
mitchellhenke/webauthn-500-2
branch
from
dba20d5 to
31a3bf0
Compare
Contributor
Author
I dug into it, and it's not clear how it happens other than when this line is called with empty strings. It doesn't fail when giving it empty strings from where we call it, so it seems to be something much deeper. verify_key.verify(hash_function, "", "")
# => OpenSSL::PKey::PKeyError: EVP_VerifyFinal: nested asn1 errorI added a spec to mock the calling method raising the exception, but it doesn't feel like it captures the root cause very well |
mitchellhenke
pushed a commit
that referenced
this pull request
Apr 4, 2022
changelog: Bug Fixes, Authentication, Fix error when unable to validate WebAuthn signature
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When verifying a WebAuthn signature, we sometimes get an exception from within OpenSSL, which causes a 500 (NR Link)