Remove idv/personal_key#download action#6162
Conversation
There was a problem hiding this comment.
🌶️ one downside to not having a server action is we no longer get the analytics
However, I still feel strongly enough that having this action on the server is a liability, so I am OK not having analytics if it means we can have a more bug-free frontend
There was a problem hiding this comment.
https://cm-jira.usa.gov/browse/LG-6111 so we can track this
There was a problem hiding this comment.
We have some precedent for front-end logging with #5875, which might be useful for this.
(Also commented as such on related ticket)
**Why**: Unused as of #6161 changelog: Internal, Source code, Remove unused download code
zachmargolis
force-pushed
the
margolis-remove-download-action
branch
from
b4ea3b6 to
e473b59
Compare
| # @deprecated | ||
| # A user has downloaded their personal key. This event is no longer emitted. |
There was a problem hiding this comment.
YAGNI?
Or is this just so that we have a reference in the analytics documentation for historical lookups?
There was a problem hiding this comment.
Yes, I figured it would be good to have a reference. And if we choose to implement frontend logging, we can link these two as "previous event names" for that or something
|
using admin merge to override code coverage dropping |
3 participants
Why: Unused as of #6161
changelog: Internal, Source code, Remove unused download code