Mark current step as invalid when in invalid state in SSN/Verify step to prevent 500#6143
Merged
mitchellhenke merged 1 commit intomainfrom Apr 4, 2022
Merged
Conversation
changelog: Bug Fixes, Identity Verification, Fix uncommon errors during proofing at the resolution and SSN steps
aduth
approved these changes
Apr 4, 2022
app/services/flow/base_step.rb
Outdated
Contributor
There was a problem hiding this comment.
I see the commit describing this as "testing", I assume we probably don't want to change the default submission to be treated as a failure 😅
Contributor
Author
There was a problem hiding this comment.
Oops, yeah, it's not intended to be merged. The nil return from the last PR ended up using the default response, so I was kind of curious how/if defaulting to failure would work.
Contributor
Author
There was a problem hiding this comment.
For what it's worth, based on CI, the answer is poorly.
mitchellhenke
force-pushed
the
mitchellhenke/fix-proofing-500
branch
from
9485962 to
811b21c
Compare
mitchellhenke
pushed a commit
that referenced
this pull request
Apr 4, 2022
…#6143) changelog: Bug Fixes, Identity Verification, Fix uncommon errors during proofing at the resolution and SSN steps
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following up to #6118, which created another 500 along similar lines. This PR ensures the current step is also marked as incomplete (NR Link)