Merged
Conversation
changelog: Internal, Logging, Log external SAML authentication requests
mitchellhenke
force-pushed
the
mitchellhenke/log-saml-auth-requests
branch
from
3b6a0d4 to
9ac4a6f
Compare
orenyk
approved these changes
Apr 5, 2022
Contributor
orenyk
left a comment
orenyk
left a comment
There was a problem hiding this comment.
Two small comments/questions, otherwise looks good to me!
zachmargolis
reviewed
Apr 5, 2022
| # @param [Integer] requested_ial | ||
| # @param [String] service_provider | ||
| # An external request for SAML Authentication was received | ||
| def saml_auth_request( |
Contributor
There was a problem hiding this comment.
❤️ thank you for adding this in the new style!
Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>
orenyk
suggested changes
Apr 5, 2022
mitchellhenke
force-pushed
the
mitchellhenke/log-saml-auth-requests
branch
from
80b594c to
906cec8
Compare
mitchellhenke
force-pushed
the
mitchellhenke/log-saml-auth-requests
branch
from
704e265 to
dced7c1
Compare
assuming specs pass!
mitchellhenke
pushed a commit
that referenced
this pull request
Apr 5, 2022
* log SAML auth requests as well * Account for authpost * check for nil * fix specs * add SAML Auth request spec changelog: Internal, Logging, Log external SAML authentication requests * add POST spec * rename analytics attributes to be clearer * simplify analytics call Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com> * move POST spec to feature spec * fix SAML post url Co-authored-by: Oren Kanner <oren.kanner@gsa.gov> Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, we log OIDC auth requests with the
OPENID_CONNECT_REQUEST_AUTHORIZATIONevent. SAML has a similar event inSAML_AUTH, but it's not quite the same. SAML will redirect internally and this event is only logged when a user is completely authenticated. This means we capture the event later in the process, and also potentially multiple times for one authentication request.This PR creates a
'SAML Auth Request'event which aims to be a closer match to the behavior on the OIDC side of logging where we log the external request only and before user authentication is required. The authentication gate on the original event is what prevented from addingexternalas an attribute rather than creating a new event.