Convert FormSteps component to native TypeScript#6172
Merged
Conversation
zachmargolis
approved these changes
Apr 7, 2022
Contributor
There was a problem hiding this comment.
Where did FC come from?
Contributor
Author
There was a problem hiding this comment.
It's imported above:
Short-hand for FunctionComponent<Props>
Contributor
Author
There was a problem hiding this comment.
In retrospect, it probably could/should be ComponentType<P>, since I don't think it must be a function component.
But, on the other hand, FC is nice and short, and conventionally-speaking, every component should be a function component anyways 😄
aduth
force-pushed
the
aduth-ts-form-steps
branch
2 times, most recently
from
983af79 to
0545e8f
Compare
**Why**: Preparatory work ahead of upcoming FlowStateMachine v2 work, where it's expected we will want to lift out this component to a shared package to reuse for other steps in the flow. [skip changelog]
aduth
force-pushed
the
aduth-ts-form-steps
branch
from
0545e8f to
b6cc6c7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why: Preparatory work ahead of upcoming FlowStateMachine v2 work, where it's expected we will want to lift out this component to a shared package to reuse for other steps in the flow.