Skip to content

Move button to components package#6173

Merged
aduth merged 2 commits intomainfrom
aduth-button-component
Apr 8, 2022
Merged

Move button to components package#6173
aduth merged 2 commits intomainfrom
aduth-button-component

Conversation

@aduth
Copy link
Contributor

@aduth aduth commented Apr 7, 2022

Why: Preparatory work ahead of upcoming FlowStateMachine v2 work, where it's expected we will want to use this component in packages outside document-capture.

For review: It appears the diff was significant enough that GitHub doesn't see it as an in-place refactor, but for transparency's sake, there's not expected to be any implementation changes to the component aside from the addition of TypeScript types.

@aduth aduth requested review from nprimak, peggles2 and solipet April 7, 2022 12:55
Copy link
Contributor

@zachmargolis zachmargolis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

aduth added 2 commits April 7, 2022 13:34
**Why**: Preparatory work ahead of upcoming FlowStateMachine v2 work, where it's expected we will want to use this component in packages outside document-capture.

[skip changelog]
@aduth aduth force-pushed the aduth-button-component branch from 68bf022 to 3064c1f Compare April 7, 2022 17:34
@aduth aduth merged commit dfb73de into main Apr 8, 2022
@aduth aduth deleted the aduth-button-component branch April 8, 2022 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants